Skip to content

Commit 9cdaf7d

Browse files
committed
KAB-46 add missing validation
1 parent efb1fd1 commit 9cdaf7d

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

kbcstorage/configurations_metadata.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@ def delete(self, component_id, configuration_id, metadata_id):
5858
if not isinstance(component_id, str) or component_id == '':
5959
raise ValueError("Invalid component_id '{}'.".format(component_id))
6060
if not isinstance(configuration_id, str) or configuration_id == '':
61-
raise ValueError("Invalid component_id '{}'.".format(configuration_id))
61+
raise ValueError("Invalid configuration_id '{}'.".format(configuration_id))
62+
if not isinstance(metadata_id, str) or metadata_id == '':
63+
raise ValueError("Invalid metadata_id '{}'.".format(metadata_id))
6264
url = '{}/{}/configs/{}/metadata/{}'.format(self.base_url, component_id, configuration_id, metadata_id)
6365
self._delete(url)
6466

kbcstorage/tables_metadata.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,12 @@ def create(self, table_id, provider, metadata, columns_metadata):
8080
"""
8181
if not isinstance(table_id, str) or table_id == '':
8282
raise ValueError("Invalid table_id '{}'.".format(table_id))
83+
if not isinstance(provider, str) or provider == '':
84+
raise ValueError("Invalid provider '{}'.".format(provider))
85+
if not isinstance(metadata, list):
86+
raise ValueError("Invalid metadata '{}'.".format(metadata))
87+
if not isinstance(columns_metadata, dict):
88+
raise ValueError("Invalid columns_metadata '{}'.".format(columns_metadata))
8389

8490
url = '{}/{}/metadata'.format(self.base_url, table_id)
8591
headers = {

0 commit comments

Comments
 (0)