Skip to content

Feature/optional files class #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kudj merged 3 commits into from
Sep 17, 2025
Merged

Feature/optional files class #88

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bb2cc8
add without_files parameter to client, allow saving memory by not imp…
kudj Sep 16, 2025
8e19379
flake8
kudj Sep 16, 2025
702f523
changed variable to positive meaning, fix docstring
kudj Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions kbcstorage/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from kbcstorage.buckets import Buckets
from kbcstorage.components import Components
from kbcstorage.configurations import Configurations
from kbcstorage.files import Files
from kbcstorage.jobs import Jobs
from kbcstorage.tables import Tables
from kbcstorage.tokens import Tokens
Expand All @@ -18,7 +17,7 @@ class Client:
Storage API Client.
"""

def __init__(self, api_domain, token, branch_id='default'):
def __init__(self, api_domain, token, branch_id='default', without_files=False):
Copy link
Copy Markdown
Contributor

@soustruh soustruh Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor readability issue, it's generally recommended to name variables in a positive way, not with a negative meaning. Instead of
if not without_files
you'd end up for example with
if initialize_files_object
which is understandable at first sight without decoding double negation. 🙂

"""
Initialise a client.

Expand All @@ -27,13 +26,18 @@ def __init__(self, api_domain, token, branch_id='default'):
"https://connection.keboola.com".
token (str): A storage API key.
branch_id (str): The ID of branch to use, use 'default' to work without branch (in main).
without_files (bool): If True saves memory by not importing files and libraries for all backends.
Copy link
Copy Markdown
Contributor

@soustruh soustruh Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma 🕵️

"""
self.root_url = api_domain.rstrip("/")
self._token = token
self._branch_id = branch_id

self.buckets = Buckets(self.root_url, self.token)
self.files = Files(self.root_url, self.token)

if not without_files:
from kbcstorage.files import Files
self.files = Files(self.root_url, self.token)

self.jobs = Jobs(self.root_url, self.token)
self.tables = Tables(self.root_url, self.token)
self.workspaces = Workspaces(self.root_url, self.token)
Expand Down