Updated ECDSA Keep unit tests

Author: nkuba

solidity/test/BondedECDSAKeepTest.js

@@ -1513,13 +1513,18 @@ contract("BondedECDSAKeep", (accounts) => {
   describe("withdraw", async () => {
     const singleValue = new BN(1000)
     const ethValue = singleValue.mul(new BN(members.length))
+    const beneficiary = accounts[4]
 
     beforeEach(async () => {
       await keep.distributeETHReward({value: ethValue})
     })
 
     it("correctly transfers value", async () => {
-      const initialMemberBalance = new BN(await web3.eth.getBalance(members[0]))
+      const initialMemberBalance = new BN(
+        await web3.eth.getBalance(beneficiary)
+      )
+
+      await tokenStaking.setBeneficiary(members[0], beneficiary)
 
       await keep.withdraw(members[0])
 
@@ -1534,17 +1539,16 @@ contract("BondedECDSAKeep", (accounts) => {
       ).to.eq.BN(0)
 
       expect(
-        await web3.eth.getBalance(members[0]),
+        await web3.eth.getBalance(beneficiary),
         "incorrect member account balance"
       ).to.eq.BN(initialMemberBalance.add(singleValue))
     })
 
     it("sends ETH to beneficiary", async () => {
       const valueWithRemainder = ethValue.add(new BN(1))
 
-      const member1 = accounts[2]
-      const member2 = accounts[3]
-      const beneficiary = accounts[4]
+      const member1 = members[0]
+      const member2 = members[1]
 
       const testMembers = [member1, member2]
 
@@ -1605,11 +1609,23 @@ contract("BondedECDSAKeep", (accounts) => {
       await expectRevert(keep.withdraw(member), "No funds to withdraw")
     })
 
+    it("reverts in case of not defined beneficiary", async () => {
+      const member = members[0]
+
+      await tokenStaking.setBeneficiary(member, constants.ZERO_ADDRESS)
+
+      await expectRevert(
+        keep.withdraw(member),
+        "Beneficiary not defined for the operator"
+      )
+    })
+
     it("reverts in case of transfer failure", async () => {
       const etherReceiver = await TestEtherReceiver.new()
       await etherReceiver.setShouldFail(true)
 
-      const member = etherReceiver.address // a receiver which we expect to reject the transfer
+      const member = members[0]
+      await tokenStaking.setBeneficiary(member, etherReceiver.address) // a receiver which we expect to reject the transfer
 
       const keep = await newKeep(
         owner,
@@ -1626,9 +1642,9 @@ contract("BondedECDSAKeep", (accounts) => {
 
       await expectRevert(keep.withdraw(member), "Transfer failed")
 
-      // Check balances of keep member's account.
+      // Check balances of keep members's beneficiary account.
       expect(
-        await web3.eth.getBalance(member),
+        await web3.eth.getBalance(etherReceiver.address),
         "incorrect member's account balance"
       ).to.eq.BN(0)
 
@@ -1646,6 +1662,10 @@ contract("BondedECDSAKeep", (accounts) => {
 
     beforeEach(async () => {
       token = await TestToken.new()
+
+      for (let i = 0; i < members.length; i++) {
+        await tokenStaking.setBeneficiary(members[i], members[i])
+      }
     })
 
     it("correctly distributes ERC20", async () => {