Remove the double check for fallback

a2kolbasov · a2kolbasov · commit 9e5a936e2a37 · 2026-01-16T03:36:18.000+03:00
diff --git a/keepassxc-browser/content/passkeys.js b/keepassxc-browser/content/passkeys.js
@@ -203,8 +203,9 @@
             if (!response.publicKey) {
                 if (!response.fallback) {
                     throwError(response?.errorCode, response?.errorMessage);
+                    return null;
                 }
-                return response.fallback ? originalCredentials.create(options) : null;
+                return originalCredentials.create(options);
             }
 
             return createPublicKeyCredential(response.publicKey);
@@ -228,8 +229,9 @@
             if (!response.publicKey) {
                 if (!response.fallback) {
                     throwError(response?.errorCode, response?.errorMessage);
+                    return null;
                 }
-                return response.fallback ? originalCredentials.get(options) : null;
+                return originalCredentials.get(options);
             }
 
             return createPublicKeyCredential(response.publicKey);

Original file line number	Diff line number	Diff line change
`@@ -203,8 +203,9 @@`
`203`	`203`	`if (!response.publicKey) {`
`204`	`204`	`if (!response.fallback) {`
`205`	`205`	`throwError(response?.errorCode, response?.errorMessage);`
	`206`	`+ return null;`
`206`	`207`	`}`
`207`		`- return response.fallback ? originalCredentials.create(options) : null;`
	`208`	`+ return originalCredentials.create(options);`
`208`	`209`	`}`
`209`	`210`
`210`	`211`	`return createPublicKeyCredential(response.publicKey);`
`@@ -228,8 +229,9 @@`
`228`	`229`	`if (!response.publicKey) {`
`229`	`230`	`if (!response.fallback) {`
`230`	`231`	`throwError(response?.errorCode, response?.errorMessage);`
	`232`	`+ return null;`
`231`	`233`	`}`
`232`		`- return response.fallback ? originalCredentials.get(options) : null;`
	`234`	`+ return originalCredentials.get(options);`
`233`	`235`	`}`
`234`	`236`
`235`	`237`	`return createPublicKeyCredential(response.publicKey);`