Skip to content

Close unlock dialog after external unlock#13328

Open
bjornmp wants to merge 1 commit into
keepassxreboot:developfrom
bjornmp:fix/close-unlock-dialog-after-external-unlock
Open

Close unlock dialog after external unlock#13328
bjornmp wants to merge 1 commit into
keepassxreboot:developfrom
bjornmp:fix/close-unlock-dialog-after-external-unlock

Conversation

@bjornmp
Copy link
Copy Markdown

@bjornmp bjornmp commented May 8, 2026

Fixes #13327

Summary

  • Close the modal database unlock dialog when its target database is unlocked through another path.
  • Keep the unlock dialog target list in DatabaseTabWidget so the dialog can still be completed if its internal state was cleared during the external unlock.
  • Complete pending Secret Service unlock requests immediately if the database is already unlocked when the dialog reports success.

Testing

  • Built KeePassXC with CMake/Ninja: cmake --build build-rel
  • Manually reproduced on KDE/Wayland with KeePassXC as Secret Service and an external MainWindow D-Bus unlock helper.
  • Verified the database unlocks and the stale unlock dialog closes after the external unlock.

AI Assistance

This patch was developed with assistance from OpenAI Codex, based on GPT-5.5. The final code was manually reviewed, built, and tested on the affected system.

@varjolintu varjolintu added the pr: ai-assisted Pull request contains significant contributions by generative AI label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: ai-assisted Pull request contains significant contributions by generative AI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unlock dialog remains open after external database unlock

2 participants