Show unsaved entry changes in entry list#13338
Conversation
Remove unnecessary code from EntryModel and place the hasUnsavedChanges into Entry itself. Add default search Add tooltip
Testing out using a modified visual indicator on the entry icon
171fa14 to
7b5f1a3
Compare
|
Thanks for taking a pass on the UI. I pushed Local validation available in this workspace: I still cannot run CMake, the unit binary, or clang-format locally because those tools are not available in this PATH. |
I removed that for a reason because it is not desired. Auto save doesnt mean the database is actually saved to disk. Saves can error out leaving the database unsaved and still modified. |
|
Thanks, that makes sense. I pushed d8ce861 to remove the AutoSaveAfterEveryChange suppression from Entry::hasUnsavedChanges(), so the indicator now still reflects a dirty database if autosave fails or leaves changes unsaved. I also updated the EntryModel regression test to expect the italic indicator while autosave is enabled and the database remains modified.\n\nLocal validation available here: git diff --check. CMake, the unit binary, and clang-format are still unavailable in this workspace PATH. |

Fixes #1162
Shows entries with unsaved local changes in italics when autosave after every change is disabled. The model compares entry modification timestamps with the current database file timestamp only while the database is dirty, so the indicator clears after save and is suppressed when autosave-after-every-change is enabled.
Generative AI disclosure: The majority of this patch was prepared with OpenAI Codex.
Screenshots
Not included; visual change is font styling only.
Testing strategy
TestEntryModel::testUnsavedEntryFont()coverage for unsaved-entry italic styling, autosave suppression, and clean-database clearing.git diff --check.cmakeandclang-formatare not available in this workspace PATH.Type of change