Rework release targets for protected main - #36
Merged
Conversation
Main's ruleset requires PRs, passing checks, and signed commits, so the old direct 'git push origin main --tags' release flow is rejected. Releases are now two phases: - make patch|minor|major: bump __version__ on a release-X.Y.Z branch from origin/main and open the release PR - make release-finish: after merge, fast-forward main, create the annotated tag (signed via tag.gpgsign), push it, and publish the GitHub release with generated notes Also guards against a dirty working tree and an already-existing tag, the two failure modes hit during the v2.0.0 release.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's ruleset (PRs + status checks + signed commits) rejects the Makefile's original direct-push release flow — discovered during the v2.0.0 release, along with two failure modes this PR guards against (releasing from a dirty tree, and a stale tag left behind when
push --tagspartially succeeds).New flow:
make patch|minor|major— bumps__version__on a freshrelease-X.Y.Zbranch cut fromorigin/main, pushes it, and opens the release PR.make release-finish— fast-forwards local main, creates the annotated tag (signed pertag.gpgsign), pushes it, and publishes the GitHub release with--generate-notes(so the release actually appears on the releases page).No code changes; Makefile only.