fix(examples): remove incorrect POST binding query string example - #64
Merged
Conversation
SAMLResponse= in a query string implies HTTP-Redirect binding (DEFLATE compressed). A POST binding SAMLResponse lives in the HTTP POST body — it only looks like a query string when intercepted. Removed the misleadingly labelled example and the encodePostBinding helper it depended on.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SAMLResponse=in a query string implies HTTP-Redirect binding (DEFLATE-compressed). POST binding sends the SAMLResponse in the HTTP POST body — it only looks like a query string when intercepted in a tool like Burp Suite.encodePostBindinghelper it depended on (now unused dead code).SAMLRequest=<deflated>&RelayState=...(redirect binding).Test plan