Skip to content

Refactor: Extract fzf argument building into reusable functions#362

Open
orb71 wants to merge 1 commit into
kelleyma49:masterfrom
orb71:orb71/refactor/fzf-argument-builder
Open

Refactor: Extract fzf argument building into reusable functions#362
orb71 wants to merge 1 commit into
kelleyma49:masterfrom
orb71:orb71/refactor/fzf-argument-builder

Conversation

@orb71
Copy link
Copy Markdown

@orb71 orb71 commented Nov 23, 2025

Replaces inline string concatenation in Invoke-Fzf with structured Add-FzfArgument and ConvertTo-FzfOption helper functions. Improves maintainability by centralizing parameter-to-option conversion logic, adds verbose tracing for debugging, and eliminates repetitive string formatting throughout the codebase.

Motivation
I wanted to add some option from 0.67.0 and I found the process quiet tedius. Now, adding option is as easy as declaring them in the Invoke-FZF param block. I will add a few when it is generaly available

Replaces inline string concatenation in Invoke-Fzf with structured
Add-FzfArgument and ConvertTo-FzfOption helper functions. Improves
maintainability by centralizing parameter-to-option conversion logic,
adds verbose tracing for debugging, and eliminates repetitive string
formatting throughout the codebase.
@orb71
Copy link
Copy Markdown
Author

orb71 commented Dec 22, 2025

Hi! @kelleyma49 I noticed there aren’t specific contribution guidelines for this repo.
I wanted to check whether this change aligns with the project’s direction.
Happy to revise or close the PR if it’s not something you want to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant