Take "batch" setting from config into account#557
Merged
Conversation
kenherring
force-pushed
the
lievendf_FixHardCodedBatchTrue
branch
from
3082bdc to
a800221
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenEdge command construction in the VSCode ABLUnit test runner so the command.batch setting from ablunit-test-profile.json controls whether -b (batch mode) is included when launching _progres/prowin.
Changes:
- Update
ABLUnitRundefault command builder to only add-bwhencommand.batchis enabled. - Update
ABLExecdefault command builder to only add-bwhencommand.batchis enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/ABLUnitRun.ts |
Makes -b conditional based on res.cfg.ablunitConfig.command.batch when building the default test-run command. |
src/ABLExec.ts |
Makes -b conditional based on cfg.ablunitConfig.command.batch when building the default exec command. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #521 to see if the builds will run.