Fix create-release action and a few lint errors#559
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the CI create-release GitHub Actions job and clean up a handful of lint-related issues across the TypeScript codebase and packaging script.
Changes:
- Fix a time conversion expression in results parsing.
- Replace several verbose null/undefined checks with optional chaining.
- Adjust the
create-releaseworkflow job condition and remove noisy packaging logs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/parse/ResultsParser.ts |
Adjusts suite time conversion arithmetic to resolve a lint issue / improve correctness. |
src/parse/OpenedgeProjectParser.ts |
Simplifies cached config guard using optional chaining. |
src/FileUtils.ts |
Uses optional chaining for workspace folder length check. |
src/DebugListingPreview.ts |
Simplifies preview editor existence/path check using optional chaining. |
scripts/package.sh |
Removes verbose logging of version components during packaging. |
.github/workflows/main.yml |
Updates create-release job conditional logic. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.