Empty dbConnections array in openedge-project profile are not used#560
Merged
Conversation
…-test-runner into fix-inherited-dbconns
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #523 in the OpenEdge project profile parsing used by the VSCode ABLUnit Test Runner, ensuring that an explicitly empty dbConnections array in an openedge-project.json profile is respected (instead of inheriting parent/default DB connections).
Changes:
- Update OpenEdge project profile merge behavior to distinguish between “unset” vs “explicitly empty”
dbConnections. - Add/extend integration and unit tests plus new test fixtures to validate DB connection inheritance/override behavior.
- Bump extension version and update changelog for the new pre-release.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/parse/OpenedgeProjectParser.ts |
Adjusts dbConnections typing/merge logic to support explicit empty arrays overriding inheritance. |
test/parse/OpenedgeProjectParser.test.ts |
Adds unit coverage for DB connection resolution across default/inherited/empty profiles. |
test/suites/proj9.test.ts |
Adds integration coverage verifying runtime behavior using a DB-count assertion test. |
test_projects/proj9/src/numdbsTest.p |
New ABLUnit test validating number of connected DBs at runtime. |
test_projects/proj9/openedge-project.test13.json |
Fixture for profile DB connection override/inheritance scenarios. |
test_projects/proj9/.vscode/ablunit-test-profile.test13.json |
Fixture test profile used by proj9 integration tests. |
test_projects/OpenedgeProjectParser/openedge-project.test7.json |
Fixture for parser unit tests around profile DB connections. |
package.json |
Version bump to 1.4.31. |
package-lock.json |
Lockfile version bump alignment to 1.4.31. |
CHANGELOG.md |
Adds 1.4.31 entry describing the fix and other release items. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #523