Skip to content

Empty dbConnections array in openedge-project profile are not used#560

Merged
kenherring merged 7 commits into
mainfrom
fix-inherited-dbconns
Apr 9, 2026
Merged

Empty dbConnections array in openedge-project profile are not used#560
kenherring merged 7 commits into
mainfrom
fix-inherited-dbconns

Conversation

@kenherring
Copy link
Copy Markdown
Owner

Fixes #523

@kenherring kenherring marked this pull request as ready for review April 9, 2026 19:17
Copilot AI review requested due to automatic review settings April 9, 2026 19:17
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #523 in the OpenEdge project profile parsing used by the VSCode ABLUnit Test Runner, ensuring that an explicitly empty dbConnections array in an openedge-project.json profile is respected (instead of inheriting parent/default DB connections).

Changes:

  • Update OpenEdge project profile merge behavior to distinguish between “unset” vs “explicitly empty” dbConnections.
  • Add/extend integration and unit tests plus new test fixtures to validate DB connection inheritance/override behavior.
  • Bump extension version and update changelog for the new pre-release.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/parse/OpenedgeProjectParser.ts Adjusts dbConnections typing/merge logic to support explicit empty arrays overriding inheritance.
test/parse/OpenedgeProjectParser.test.ts Adds unit coverage for DB connection resolution across default/inherited/empty profiles.
test/suites/proj9.test.ts Adds integration coverage verifying runtime behavior using a DB-count assertion test.
test_projects/proj9/src/numdbsTest.p New ABLUnit test validating number of connected DBs at runtime.
test_projects/proj9/openedge-project.test13.json Fixture for profile DB connection override/inheritance scenarios.
test_projects/proj9/.vscode/ablunit-test-profile.test13.json Fixture test profile used by proj9 integration tests.
test_projects/OpenedgeProjectParser/openedge-project.test7.json Fixture for parser unit tests around profile DB connections.
package.json Version bump to 1.4.31.
package-lock.json Lockfile version bump alignment to 1.4.31.
CHANGELOG.md Adds 1.4.31 entry describing the fix and other release items.

Comment thread src/parse/OpenedgeProjectParser.ts
Comment thread CHANGELOG.md
Comment thread CHANGELOG.md Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2026

@kenherring kenherring merged commit 1146717 into main Apr 9, 2026
15 of 16 checks passed
@kenherring kenherring deleted the fix-inherited-dbconns branch April 9, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug] dbConnections in openedgeProjectProfile are not used

2 participants