Clear environment variable when initializationProcedure is no longer set#565
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a regression where initializationProcedure could continue to be used after being removed from the test profile by explicitly clearing the related environment variable, and improves runner-side handling when an initialization procedure can’t be located.
Changes:
- Clear
ABLUNIT_INITIALIZATION_PROCEDUREwhen noinitializationProcedureis configured. - Add an ABL-side
search()check and throw a clearer error if the initialization procedure isn’t found. - Bump extension version and update changelog entries.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ABLUnitRun.ts | Clears the initialization procedure env var when the config no longer provides it. |
| resources/VSCodeTestRunner/ABLUnitCore.p | Validates the initialization procedure exists before running it; adds a safer CallStack display check. |
| package.json | Version bump to 1.4.33. |
| package-lock.json | Lockfile version bump to 1.4.33. |
| CHANGELOG.md | Adds release notes for 1.4.33 and updates compare link text/link. |
Agent-Logs-Url: https://github.com/kenherring/ablunit-test-runner/sessions/14b01610-5c17-4933-b145-54cdfb1bf2f9 Co-authored-by: kenherring <3201462+kenherring@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #494