Trim windows- from codepage#567
Merged
Merged
Conversation
|
There was a problem hiding this comment.
Pull request overview
Fixes incorrect OpenEdge -cpstream values derived from openedge-project.json by normalizing Windows-style charset strings.
Changes:
- Trim
windows-prefix from the configured charset before passing it to-cpstream. - Add a Windows-only integration test project config (
windows-1252) and corresponding test case. - Bump extension version and update changelog entry.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test_projects/proj1/openedge-project.proj1.17.json | Adds an OpenEdge project config fixture using charset: windows-1252 for testing. |
| test/suites/proj1.test.ts | Adds an integration test verifying tests run when charset is windows-1252 (Windows-only). |
| src/parse/TestProfileParser.ts | Normalizes charset by removing windows- prefix before adding/replacing -cpstream. |
| package.json | Bumps extension version to 1.4.35. |
| package-lock.json | Updates lockfile version fields to 1.4.35. |
| CHANGELOG.md | Documents the change and updates release header/compare link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458