Create a testing environment in NodeJS and using modern JS syntax#28
Open
hienphamlabs wants to merge 2 commits intokennymkchan:masterfrom
hienphamlabs:master
Open
Create a testing environment in NodeJS and using modern JS syntax#28hienphamlabs wants to merge 2 commits intokennymkchan:masterfrom hienphamlabs:master
hienphamlabs wants to merge 2 commits intokennymkchan:masterfrom
hienphamlabs:master
Conversation
Contributor
|
Can you also add .vscode/ and yarn.lock to your .gitignore? While I agree there should be ES6 examples (which is something I am also working on), I think they should be separated from the existing examples |
craigayre
reviewed
Feb 19, 2017
| var unsortedArray = [-10, 7, 29, 30, 5, -10, -70]; | ||
| const unsortedArray = [-10, 7, 29, 30, 5, -10, -70]; | ||
|
|
||
| computeProduct(unsortedArray); // 21000 |
Contributor
There was a problem hiding this comment.
This does not work since computeProduct is now not hoisted
craigayre
reviewed
Feb 22, 2017
|
|
||
| ## Want to Test Solutions ? | ||
| __[Demo and testing](demo)__ | ||
| - `npm install` or `yarn install` |
Contributor
There was a problem hiding this comment.
You could replace yarn install with just yarn
Contributor
There was a problem hiding this comment.
Also, to be consistent with install, it might be worth adding how you test with yarn (yarn test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first change is just in array compute product.