Fix lint warnings and stabilize Cloudflare transcript-format tests.

kentcdodds · kentcdodds · commit b72fabe94772 · 2026-03-09T10:59:37.000-06:00
Make lint-driven cleanup changes across route and utility modules, and isolate transcript formatting tests from local Cloudflare credentials by setting mock env values explicitly.

Made-with: Cursor
diff --git a/app/bootstrap.client.tsx b/app/bootstrap.client.tsx
@@ -0,0 +1 @@
+export {}
diff --git a/app/components/calls/recording-form.tsx b/app/components/calls/recording-form.tsx
@@ -136,7 +136,7 @@ export function RecordingForm({
 					? {
 							...prev,
 							errors: {
-								...(prev.errors ?? {}),
+								...prev.errors,
 								generalError: undefined,
 								[field]: null,
 							} as RecordingFormData['errors'],
diff --git a/app/other-routes.server.ts b/app/other-routes.server.ts
@@ -18,14 +18,14 @@ const pathedRoutes: Record<string, Handler> = {
 	},
 }
 
-const routes: Array<Handler> = [
-	...Object.entries(pathedRoutes).map(([path, handler]) => {
+const routes: Array<Handler> = Object.entries(pathedRoutes).map(
+	([path, handler]) => {
 		return (request: Request, remixContext: EntryContext) => {
 			if (new URL(request.url).pathname !== path) return null
 
 			return handler(request, remixContext)
 		}
-	}),
-]
+	},
+)
 
 export { routes, pathedRoutes }
diff --git a/app/routes/blog.tsx b/app/routes/blog.tsx
@@ -606,7 +606,7 @@ function BlogHome({ loaderData: data }: Route.ComponentProps) {
 										selected={selected}
 										onClick={() => toggleTag(tag)}
 										disabled={
-											Boolean(!visibleTags.has(tag)) ? !selected : false
+											!visibleTags.has(tag) ? !selected : false
 										}
 									/>
 								)
diff --git a/app/routes/calls/$season/$episode/$slug.tsx b/app/routes/calls/$season/$episode/$slug.tsx
@@ -49,8 +49,13 @@ export const meta: MetaFunction<
 	typeof loader,
 	{ root: RootLoaderType; 'routes/calls/_layout': typeof callsLoader }
 > = ({ matches, params }) => {
-	const { requestInfo } = matches.find((m) => m.id === 'root')
-		?.data as SerializeFrom<typeof rootLoader>
+	const rootData = matches.find((m) => m.id === 'root')
+		?.data as SerializeFrom<typeof rootLoader> | undefined
+	if (!rootData) {
+		return [{ title: 'Call not found' }]
+	}
+
+	const { requestInfo } = rootData
 	const callsData = matches.find((m) => m.id === 'routes/calls/_layout')
 		?.data as SerializeFrom<typeof callsLoader> | undefined
 	if (!callsData) {
diff --git a/app/routes/mcp/mcp.server.ts b/app/routes/mcp/mcp.server.ts
@@ -349,9 +349,9 @@ function createServer() {
 					},
 					{
 						type: 'text',
-						text:
-							`Transcript:\n\n${episode.transcriptHTML}` ||
-							`Transcript: No transcript found for ${episode.title} (Chats with Kent S${seasonNumber}E${episodeNumber})`,
+						text: episode.transcriptHTML
+							? `Transcript:\n\n${episode.transcriptHTML}`
+							: `Transcript: No transcript found for ${episode.title} (Chats with Kent S${seasonNumber}E${episodeNumber})`,
 					},
 				],
 			}
diff --git a/app/routes/talks/$slug.tsx b/app/routes/talks/$slug.tsx
@@ -16,8 +16,12 @@ export const meta: MetaFunction<
 		(matches.find((m) => m.id === 'routes/talks/_layout')?.data as
 			| SerializeFrom<typeof talkLoader>
 			| undefined) ?? {}
-	const { requestInfo } = matches.find((m) => m.id === 'root')
-		?.data as SerializeFrom<RootLoaderType>
+	const rootData = matches.find((m) => m.id === 'root')
+		?.data as SerializeFrom<RootLoaderType> | undefined
+	if (!rootData) {
+		return [{ title: '404: Talk not found' }]
+	}
+	const { requestInfo } = rootData
 
 	const talk = params.slug ? talks.find((t) => t.slug === params.slug) : null
 	const title = talk ? talk.title : '404: Talk not found'
diff --git a/app/utils/__tests__/call-kent-transcript-format.server.test.ts b/app/utils/__tests__/call-kent-transcript-format.server.test.ts
@@ -1,5 +1,6 @@
 import { expect, test } from 'vitest'
 import { formatCallKentTranscriptWithWorkersAi } from '#app/utils/cloudflare-ai-call-kent-transcript-format.server.ts'
+import { setEnv } from '#tests/env-disposable.ts'
 
 test('formatCallKentTranscriptWithWorkersAi rejects empty transcripts', async () => {
 	await expect(
@@ -8,6 +9,14 @@ test('formatCallKentTranscriptWithWorkersAi rejects empty transcripts', async ()
 })
 
 test('formatCallKentTranscriptWithWorkersAi returns paragraphs and preserves separators', async () => {
+	using _env = setEnv({
+		CLOUDFLARE_API_TOKEN: 'MOCK_CLOUDFLARE_API_TOKEN',
+		CLOUDFLARE_ACCOUNT_ID: 'mock-account',
+		CLOUDFLARE_AI_GATEWAY_ID: 'mock-gateway',
+		CLOUDFLARE_AI_GATEWAY_AUTH_TOKEN: 'MOCK_CLOUDFLARE_AI_GATEWAY_AUTH_TOKEN',
+		CLOUDFLARE_AI_CALL_KENT_TRANSCRIPT_FORMAT_MODEL: '@cf/meta/llama-3.1-8b-instruct',
+	})
+
 	const transcript = `
 Announcer: You're listening to the Call Kent Podcast. Now let's hear the call.
 
@@ -39,13 +48,29 @@ Announcer: This has been the Call Kent Podcast. Thanks for listening.
 })
 
 test('formatCallKentTranscriptWithWorkersAi works without --- separators', async () => {
+	using _env = setEnv({
+		CLOUDFLARE_API_TOKEN: 'MOCK_CLOUDFLARE_API_TOKEN',
+		CLOUDFLARE_ACCOUNT_ID: 'mock-account',
+		CLOUDFLARE_AI_GATEWAY_ID: 'mock-gateway',
+		CLOUDFLARE_AI_GATEWAY_AUTH_TOKEN: 'MOCK_CLOUDFLARE_AI_GATEWAY_AUTH_TOKEN',
+		CLOUDFLARE_AI_CALL_KENT_TRANSCRIPT_FORMAT_MODEL: '@cf/meta/llama-3.1-8b-instruct',
+	})
+
 	const transcript = `Caller: Hi Kent. This is a single block transcript. It should still get paragraph breaks.`
 	const formatted = await formatCallKentTranscriptWithWorkersAi({ transcript })
 	expect(formatted).toContain('Caller:')
 	expect(formatted).toMatch(/[.!?]\n\n/)
 })
 
 test('formatCallKentTranscriptWithWorkersAi does not truncate long transcripts', async () => {
+	using _env = setEnv({
+		CLOUDFLARE_API_TOKEN: 'MOCK_CLOUDFLARE_API_TOKEN',
+		CLOUDFLARE_ACCOUNT_ID: 'mock-account',
+		CLOUDFLARE_AI_GATEWAY_ID: 'mock-gateway',
+		CLOUDFLARE_AI_GATEWAY_AUTH_TOKEN: 'MOCK_CLOUDFLARE_AI_GATEWAY_AUTH_TOKEN',
+		CLOUDFLARE_AI_CALL_KENT_TRANSCRIPT_FORMAT_MODEL: '@cf/meta/llama-3.1-8b-instruct',
+	})
+
 	const longBody = Array.from(
 		{ length: 600 },
 		(_, i) => `Sentence ${i + 1}.`,
diff --git a/app/utils/__tests__/cloudflare-ai-utils.server.test.ts b/app/utils/__tests__/cloudflare-ai-utils.server.test.ts
@@ -3,7 +3,7 @@ import { setEnv } from '#tests/env-disposable.ts'
 import { getWorkersAiRunUrl } from '../cloudflare-ai-utils.server.ts'
 
 test('getWorkersAiRunUrl routes embeddinggemma requests through CLOUDFLARE_AI_EMBEDDING_GATEWAY_ID', () => {
-	using ignoredEnv = setEnv({
+	using _ignoredEnv = setEnv({
 		CLOUDFLARE_ACCOUNT_ID: 'cf-account',
 		CLOUDFLARE_AI_GATEWAY_ID: 'runtime-gateway',
 		CLOUDFLARE_AI_EMBEDDING_GATEWAY_ID: 'embedding-gateway',
@@ -15,7 +15,7 @@ test('getWorkersAiRunUrl routes embeddinggemma requests through CLOUDFLARE_AI_EM
 })
 
 test('getWorkersAiRunUrl keeps non-embedding models on CLOUDFLARE_AI_GATEWAY_ID', () => {
-	using ignoredEnv = setEnv({
+	using _ignoredEnv = setEnv({
 		CLOUDFLARE_ACCOUNT_ID: 'cf-account',
 		CLOUDFLARE_AI_GATEWAY_ID: 'runtime-gateway',
 		CLOUDFLARE_AI_EMBEDDING_GATEWAY_ID: 'embedding-gateway',
@@ -27,7 +27,7 @@ test('getWorkersAiRunUrl keeps non-embedding models on CLOUDFLARE_AI_GATEWAY_ID'
 })
 
 test('getWorkersAiRunUrl prefers explicit gatewayId overrides', () => {
-	using ignoredEnv = setEnv({
+	using _ignoredEnv = setEnv({
 		CLOUDFLARE_ACCOUNT_ID: 'cf-account',
 		CLOUDFLARE_AI_GATEWAY_ID: 'runtime-gateway',
 		CLOUDFLARE_AI_EMBEDDING_GATEWAY_ID: 'embedding-gateway',
diff --git a/app/utils/__tests__/semantic-search.server.test.ts b/app/utils/__tests__/semantic-search.server.test.ts
@@ -22,7 +22,7 @@ vi.mock('#app/utils/semantic-search-presentation.server.ts', () => ({
 import { semanticSearchKCD } from '../semantic-search.server.ts'
 
 test('semanticSearchKCD routes user query embeddings through CLOUDFLARE_AI_EMBEDDING_GATEWAY_ID', async () => {
-	using ignoredEnv = setEnv({
+	using _ignoredEnv = setEnv({
 		CLOUDFLARE_ACCOUNT_ID: 'cf-account',
 		CLOUDFLARE_API_TOKEN: 'cf-token',
 		CLOUDFLARE_AI_GATEWAY_ID: 'runtime-search-gateway',
@@ -78,7 +78,7 @@ test('semanticSearchKCD routes user query embeddings through CLOUDFLARE_AI_EMBED
 })
 
 test('semanticSearchKCD canonicalizes YouTube results by video id from URL when slug is missing', async () => {
-	using ignoredEnv = setEnv({
+	using _ignoredEnv = setEnv({
 		CLOUDFLARE_ACCOUNT_ID: 'mock-account',
 		CLOUDFLARE_API_TOKEN: 'mock-token',
 		CLOUDFLARE_AI_GATEWAY_ID: 'runtime-search-gateway',
diff --git a/app/utils/listify.ts b/app/utils/listify.ts
@@ -1,26 +1,10 @@
-// unfortunately TypeScript doesn't have Intl.ListFormat yet 😢
-// so we'll just add it ourselves. Unfortunately, adding it overrides Intl
-// in the file we have this code in, so we leave it all by itself...
-// Like the outcast it is...
-type ListFormatOptions = {
-	type?: 'conjunction' | 'disjunction' | 'unit'
-	style?: 'long' | 'short' | 'narrow'
-	localeMatcher?: 'lookup' | 'best fit'
-}
-declare namespace Intl {
-	class ListFormat {
-		constructor(locale: string, options: ListFormatOptions)
-		public format: (items: Array<string>) => string
-	}
-}
-
 type ToStringable = {
 	toString(): string
 }
 
 type ListifyOptions<ItemType extends ToStringable> = {
-	type?: ListFormatOptions['type']
-	style?: ListFormatOptions['style']
+	type?: Intl.ListFormatOptions['type']
+	style?: Intl.ListFormatOptions['style']
 	stringify?: (item: ItemType) => string
 }
 
diff --git a/app/utils/mdx.server.ts b/app/utils/mdx.server.ts
@@ -163,7 +163,7 @@ export async function getBlogMdxListItems(options: CachifiedOptions) {
 				return aTime > zTime ? -1 : aTime === zTime ? 0 : 1
 			})
 
-			return pages.map(({ code, ...rest }) => rest)
+			return pages.map(({ code: _code, ...rest }) => rest)
 		},
 	})
 }
diff --git a/app/utils/mdx.tsx b/app/utils/mdx.tsx
@@ -56,7 +56,8 @@ const mdxPageMeta: MetaFunction<MetaLoader, { root: RootLoaderType }> = ({
 		// NOTE: keyword metadata is not used because it was used and abused by
 		// spammers. We use them for sorting on our own site, but we don't list
 		// it in the meta tags because it's possible to be penalized for doing so.
-		const { keywords, ...extraMetaInfo } = data.page.frontmatter.meta ?? {}
+		const { keywords: _keywords, ...extraMetaInfo } =
+			data.page.frontmatter.meta ?? {}
 		const extraMeta: ExtraMeta = Object.entries(extraMetaInfo).reduce(
 			(acc: ExtraMeta, [key, val]) => [...acc, { [key]: String(val) }],
 			[],
diff --git a/app/utils/not-found-suggestions.server.ts b/app/utils/not-found-suggestions.server.ts
@@ -336,7 +336,7 @@ function getQueryCandidates({
 			? notFoundQueryFromPathname(segments.slice(1).join('/'))
 			: ''
 	const rawPathQuery = normalizeText(
-		normalized.replace(/^\/+/, '').replace(/[-_.\/]+/g, ' '),
+		normalized.replace(/^\/+/, '').replace(/[-_./]+/g, ' '),
 	)
 
 	const candidates = [
@@ -363,7 +363,7 @@ const matchSorterOptions = {
 		{ key: 'title', threshold: matchSorterRankings.CONTAINS },
 		{
 			key: (i: NotFoundDeterministicIndexItem) =>
-				normalizeText(i.url.replace(/[-_.\/]+/g, ' ')),
+				normalizeText(i.url.replace(/[-_./]+/g, ' ')),
 			threshold: matchSorterRankings.CONTAINS,
 			maxRanking: matchSorterRankings.CONTAINS,
 		},
diff --git a/app/utils/semantic-search.server.ts b/app/utils/semantic-search.server.ts
@@ -206,7 +206,7 @@ async function cloudflareFetch(
 		...init,
 		headers: {
 			Authorization: `Bearer ${apiToken}`,
-			...(init.headers ?? {}),
+			...init.headers,
 		},
 	})
 
diff --git a/other/semantic-search/__tests__/cloudflare-config.test.ts b/other/semantic-search/__tests__/cloudflare-config.test.ts
@@ -3,7 +3,7 @@ import { setEnv } from '#tests/env-disposable.ts'
 import { getCloudflareConfig } from '../cloudflare.ts'
 
 test('getCloudflareConfig prefers embedding gateway for indexing when configured', () => {
-	using ignoredEnv = setEnv({
+	using _ignoredEnv = setEnv({
 		CLOUDFLARE_ACCOUNT_ID: 'cf-account',
 		CLOUDFLARE_API_TOKEN: 'cf-token',
 		CLOUDFLARE_AI_GATEWAY_ID: 'runtime-gateway',
@@ -17,7 +17,7 @@ test('getCloudflareConfig prefers embedding gateway for indexing when configured
 })
 
 test('getCloudflareConfig throws when embedding gateway is unset', () => {
-	using ignoredEnv = setEnv({
+	using _ignoredEnv = setEnv({
 		CLOUDFLARE_ACCOUNT_ID: 'cf-account',
 		CLOUDFLARE_API_TOKEN: 'cf-token',
 		CLOUDFLARE_AI_GATEWAY_ID: 'runtime-gateway',
diff --git a/other/semantic-search/chunk-utils.ts b/other/semantic-search/chunk-utils.ts
@@ -183,7 +183,7 @@ export async function mapWithConcurrency<Item, Result>(
 	mapper: (item: Item, index: number) => Promise<Result>,
 ) {
 	const safeConcurrency = Math.max(1, Math.min(concurrency, items.length || 1))
-	const results: Result[] = new Array(items.length)
+	const results = Array.from({ length: items.length }) as Result[]
 	let nextIndex = 0
 	let failed = false
 	let hasError = false
diff --git a/other/semantic-search/cloudflare.ts b/other/semantic-search/cloudflare.ts
@@ -83,7 +83,7 @@ async function cfFetch(
 				...(path.startsWith(workersAiPrefix)
 					? { 'cf-aig-authorization': `Bearer ${gatewayAuthToken}` }
 					: null),
-				...(init.headers ?? {}),
+					...init.headers,
 			},
 		}).catch((e) => {
 			// network/timeout
diff --git a/other/semantic-search/index-youtube-playlist.ts b/other/semantic-search/index-youtube-playlist.ts
@@ -1049,7 +1049,7 @@ async function mapWithConcurrency<Item, Result>(
 	concurrency: number,
 	mapper: (item: Item, index: number) => Promise<Result>,
 ) {
-	const results: Result[] = new Array(items.length)
+	const results = Array.from({ length: items.length }) as Result[]
 	let nextIndex = 0
 	const workers = Array.from({ length: Math.max(1, concurrency) }, async () => {
 		while (nextIndex < items.length) {
diff --git a/other/semantic-search/youtube-transcript-cue-filter.ts b/other/semantic-search/youtube-transcript-cue-filter.ts
@@ -16,7 +16,7 @@ export function isLowSignalYoutubeCaptionCueLine(line: string) {
 	if (!normalized) return true
 
 	// Caption tracks often include non-semantic cues like `[Music]`.
-	const cueOnlyBracketedPattern = /^(?:\[[^\]]+\](?:[\s.,!?;:\/\\-]*)?)+$/u
+	const cueOnlyBracketedPattern = /^(?:\[[^\]]+\](?:[\s.,!?;:/\\-]*)?)+$/u
 	if (cueOnlyBracketedPattern.test(normalized)) return true
 
 	return BARE_CUE_WORDS.has(normalized.toLowerCase())

Original file line number	Diff line number	Diff line change
`@@ -606,7 +606,7 @@ function BlogHome({ loaderData: data }: Route.ComponentProps) {`
`606`	`606`	`selected={selected}`
`607`	`607`	`onClick={() => toggleTag(tag)}`
`608`	`608`	`disabled={`
`609`		`- Boolean(!visibleTags.has(tag)) ? !selected : false`
	`609`	`+ !visibleTags.has(tag) ? !selected : false`
`610`	`610`	`}`
`611`	`611`	`/>`
`612`	`612`	`)`
Original file line number	Diff line number	Diff line change
`@@ -349,9 +349,9 @@ function createServer() {`
`349`	`349`	`},`
`350`	`350`	`{`
`351`	`351`	`type: 'text',`
`352`		`- text:`
`353`		- `Transcript:\n\n${episode.transcriptHTML}` \|\|
`354`		- `Transcript: No transcript found for ${episode.title} (Chats with Kent S${seasonNumber}E${episodeNumber})`,
	`352`	`+ text: episode.transcriptHTML`
	`353`	+ ? `Transcript:\n\n${episode.transcriptHTML}`
	`354`	+ : `Transcript: No transcript found for ${episode.title} (Chats with Kent S${seasonNumber}E${episodeNumber})`,
`355`	`355`	`},`
`356`	`356`	`],`
`357`	`357`	`}`