Skip to content

Always install Playwright browsers in CI#735

Draft
kentcdodds wants to merge 1 commit intomainfrom
cursor/playwright-ci-job-9363
Draft

Always install Playwright browsers in CI#735
kentcdodds wants to merge 1 commit intomainfrom
cursor/playwright-ci-job-9363

Conversation

@kentcdodds
Copy link
Copy Markdown
Owner

Summary

  • always run the Playwright browser install step in the site verify job
  • always run the Playwright browser install step in the Playwright job
  • keep the cache, but stop treating a cache hit as proof that Chromium is usable

Testing

  • cp services/site/.env.example services/site/.env
  • npm run test:e2e:install --workspace kentcdodds.com
  • npm run ci:verify --workspace=kentcdodds.com
  • cd services/site && npx prisma migrate reset --force
  • npm run prime-cache:mocks --workspace kentcdodds.com
  • cd services/site && CI=1 PORT=8811 npx playwright test
Open in Web Open in Cursor 

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 16, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3d797b66-814c-4ded-a2ec-5d92c2f3fd6d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/playwright-ci-job-9363
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants