Fix falsy-zero bug in BST validation, deduplicate TreeNode#2742
Merged
Conversation
- Fix bst_validate_bst.py: replace all truthiness checks on min/max values with explicit `is not None` checks, fixing incorrect results for BSTs containing 0 (#2732) - Replace local TreeNode class definitions with imports from algorithms.common.tree_node in 4 compatible tree files (#2725) Closes #2725, closes #2732 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bst_validate_bst.py: replace all truthiness checks on min/max values with explicitis not Nonechecks, fixing incorrect validation for BSTs containing0(Bug: Falsy-zero bug in bst_validate_bst.py — wrong result for trees containing 0 #2732)TreeNodeclass definitions with imports fromalgorithms.common.tree_nodein 4 compatible files (Deduplicate TreeNode — use common/tree_node.py instead of local redefinitions #2725)Test plan
python -m pytest tests/test_tree.py -x -q— 11 tests pass0class TreeNodein changed filesCloses #2725, #2732
🤖 Generated with Claude Code