fix: Fix PointLayer polygon filtering for GeoJSON column mode#3410
Merged
Conversation
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes polygon/rectangle filtering behavior for PointLayer when using GeoJSON column mode by ensuring polygon filtering operates on parsed numeric coordinates (including MultiPoint-like cases) rather than raw GeoJSON/WKT values.
Changes:
- Update polygon filter functor to use
layer.dataToFeaturecoordinates for point/icon layers when available. - Fix
PointLayerGeoJSON column mode to indexdataToFeatureby the underlying row index (filteredIndex[i]) instead of the loop counter. - Add node tests covering polygon filtering for point layers in GeoJSON column mode, including MultiPoint behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/node/utils/filter-utils-test.js | Adds coverage for polygon filtering with dataToFeature (GeoJSON column mode) and MultiPoint semantics. |
| src/utils/src/filter-utils.ts | Adjusts polygon filtering logic for point/icon layers to use dataToFeature coordinates. |
| src/layers/src/point-layer/point-layer.ts | Corrects dataToFeature indexing in GeoJSON column mode when iterating filtered rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
lixun910
approved these changes
May 3, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.