Fix: Geocoder pin should place location at the bottom#3421
Merged
Conversation
Collaborator
igorDykhta
commented
May 6, 2026
igorDykhta
commented
- a correct fix for Geocoder pin place instead of wrong fix: anchor geocoder pin icon at bottom tip (#2401) #3320
- For [Bug] Geocoder pin should place location at the bottom #2401
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the geocoder “place” pin icon is positioned so that its bottom tip (rather than its center) aligns with the searched geographic coordinate, addressing the visual offset described in #2401.
Changes:
- Adds special-case icon-geometry anchoring for the geocoder layer so the
placeicon is anchored at its bottom. - Scales the anchored geometry and compensates by increasing the geocoder icon radius constant.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/layers/src/icon-layer/icon-layer.ts |
Adds a geocoder-layer-specific getIconGeometry wrapper to bottom-anchor (and scale) the place icon geometry before rendering. |
src/constants/src/default-settings.ts |
Doubles GEOCODER_ICON_SIZE to compensate for the new geometry scaling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ilyabo
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.