Skip to content

fix(go-services): mysql healthcheck false-healthy race (kafka-ecommerce CI flake) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slayerjain wants to merge 1 commit into
base: go
Choose a base branch
from
Open

fix(go-services): mysql healthcheck false-healthy race (kafka-ecommerce CI flake) #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions go-services/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,19 @@ services:
volumes:
- ./user_service/db.sql:/docker-entrypoint-initdb.d/init.sql
healthcheck:
test: [ "CMD", "mysqladmin", "ping", "-h", "localhost" ]
# TCP+creds probe: only the fully-started real server on :3306 answers.
# The old `ping -h localhost` hit MySQL 8.0's socket-only TEMPORARY init
# server and passed on exit-code-only (even "Access denied"), so the
# container was marked healthy ~3s before the real :3306 listener was up.
# A dependent service connecting over TCP then started too early and
# failed during the temp-server -> real-server restart gap (intermittent
# "container unhealthy" / "dependency failed to start" in CI).
test: [ "CMD", "mysqladmin", "ping", "-h", "127.0.0.1", "-P", "3306", "-uroot", "-proot" ]
interval: 5s
timeout: 5s
retries: 20
# Cold init (slow under CI contention) shouldn't burn the retry budget.
start_period: 60s

mysql-products:
image: mysql:8.0
Expand All @@ -34,10 +43,19 @@ services:
volumes:
- ./product_service/db.sql:/docker-entrypoint-initdb.d/init.sql
healthcheck:
test: [ "CMD", "mysqladmin", "ping", "-h", "localhost" ]
# TCP+creds probe: only the fully-started real server on :3306 answers.
# The old `ping -h localhost` hit MySQL 8.0's socket-only TEMPORARY init
# server and passed on exit-code-only (even "Access denied"), so the
# container was marked healthy ~3s before the real :3306 listener was up.
# A dependent service connecting over TCP then started too early and
# failed during the temp-server -> real-server restart gap (intermittent
# "container unhealthy" / "dependency failed to start" in CI).
test: [ "CMD", "mysqladmin", "ping", "-h", "127.0.0.1", "-P", "3306", "-uroot", "-proot" ]
interval: 5s
timeout: 5s
retries: 20
# Cold init (slow under CI contention) shouldn't burn the retry budget.
start_period: 60s

mysql-orders:
image: mysql:8.0
Expand All @@ -54,10 +72,19 @@ services:
volumes:
- ./order_service/db.sql:/docker-entrypoint-initdb.d/init.sql
healthcheck:
test: [ "CMD", "mysqladmin", "ping", "-h", "localhost" ]
# TCP+creds probe: only the fully-started real server on :3306 answers.
# The old `ping -h localhost` hit MySQL 8.0's socket-only TEMPORARY init
# server and passed on exit-code-only (even "Access denied"), so the
# container was marked healthy ~3s before the real :3306 listener was up.
# A dependent service connecting over TCP then started too early and
# failed during the temp-server -> real-server restart gap (intermittent
# "container unhealthy" / "dependency failed to start" in CI).
test: [ "CMD", "mysqladmin", "ping", "-h", "127.0.0.1", "-P", "3306", "-uroot", "-proot" ]
interval: 5s
timeout: 5s
retries: 20
# Cold init (slow under CI contention) shouldn't burn the retry budget.
start_period: 60s

zookeeper:
image: confluentinc/cp-zookeeper:7.5.0
Expand Down