reusable api as class instead of singleton#68
Open
cornerman wants to merge 1 commit into
Open
Conversation
cainlevy
reviewed
Feb 20, 2024
Member
cainlevy
left a comment
cainlevy
left a comment
There was a problem hiding this comment.
this looks reasonable. my memory was of a bigger difference, maybe due to the inclusion of backwards compatibility shims.
Contributor
Author
|
@cainlevy Anything speaks against merging this? Let me know, if we need to update something here. |
cainlevy
requested changes
May 29, 2024
Member
cainlevy
left a comment
cainlevy
left a comment
There was a problem hiding this comment.
Thanks for the bump. I'm ✅ on the bundle size changes. Would you look at some update to the README about how to use the library without relying on the global instance? I'd like to take a quick look at that before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the api part of AuthN reusable. AuthN itself would remain a singleton.
It actually does increase bundle size as @cainlevy already predicted.
First, I just added the API class using normal member methods, and I got the following results:
Then I realized that the methods of API will break if we export them just like this, because of the this binding, so i used arrow functions:
Then I thought, we could maybe safe some more bytes with arrow functions in the SessionManager:
The current main is still a bit smaller though:
fixes #67