Skip to content

fix: align zip stream enqueue types to satisfy TypeScript#343

Open
kern wants to merge 1 commit into
mainfrom
codex/update-npm-modules-and-validate-tests-pagu08
Open

fix: align zip stream enqueue types to satisfy TypeScript#343
kern wants to merge 1 commit into
mainfrom
codex/update-npm-modules-and-validate-tests-pagu08

Conversation

@kern
Copy link
Copy Markdown
Owner

@kern kern commented Jan 19, 2026

Motivation

  • Fix a TypeScript type mismatch (TS2345) when enqueuing file metadata into the zip stream so the build/typecheck stops failing.

Description

  • Cast the readable stream controller to a writer-shaped interface and enqueue DownloadFileStream objects via zipController.enqueue(...) instead of the incorrect ArrayBufferView cast, and call zipController.close() when done.

Testing

  • Ran pnpm type:check (i.e. tsc --noEmit) and the type check completed successfully.

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant