Apply Commissions to PnL and PnL Percentage.

[abhirathmahipal]

No description provided.

[abhirathmahipal]

Will take up pl_pct and commission calculation bugs in the next CR.

This should fix the PnL fields and other downstream calculations in compute_stats.

[kernc]

Why not apply the same subtraction (-self._commissions) to Trade.pl_pct though? I.e. to keep the two PL values in sync. 🟦

Not much should change other than some test values? 🤔

[abhirathmahipal]

Why not apply the same subtraction (-self._commissions) to Trade.pl_pct though? I.e. to keep the two PL values in sync. 🟦

This would work for Broker but not for Trade. If parity has to be maintained in Trade, we'll have to factor commission into per unit price.

[abhirathmahipal]

Let's merge this?

As mentioned above

Will take up pl_pct and commission calculation bugs in the next CR.

[kernc]

Thanks! The implementation is convoluted and bug-prone, but it's been like that before. I also notice there are few tests covering trading with commissions applied. But now at least the two properties are consistent with each other. Thanks again!

[abhirathmahipal]

The implementation is convoluted and bug-prone, but it's been like that before.

That's the reason I just wanted to go for PnL.