Skip to content

Commit 87a3f5c

Browse files
mstrozekbroonie
authored andcommitted
ASoC: sdw_utils: cs42l43: allow spk component names to be combined
Move handling of cs42l43-spk component string into SOF mechanism [1] which will allow it to be aggregated with other speakers. Likewise handle the cs35l56-bridge special case which should not be combined to keep compatibility with UCM. Link: thesofproject/linux#5445 [1] Link: alsa-project/alsa-ucm-conf#747 Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com> Suggested-by: Aaron Ma <aaron.ma@canonical.com> Tested-by: Aaron Ma <aaron.ma@canonical.com> Link: https://patch.msgid.link/20260420114823.194226-1-mstrozek@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 0a5ee0e commit 87a3f5c

3 files changed

Lines changed: 17 additions & 21 deletions

File tree

sound/soc/sdw_utils/soc_sdw_bridge_cs35l56.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,6 @@ static int asoc_sdw_bridge_cs35l56_asp_init(struct snd_soc_pcm_runtime *rtd)
4040
struct snd_soc_dai *codec_dai;
4141
struct snd_soc_dai *cpu_dai;
4242

43-
card->components = devm_kasprintf(card->dev, GFP_KERNEL,
44-
"%s spk:cs35l56-bridge",
45-
card->components);
46-
if (!card->components)
47-
return -ENOMEM;
48-
4943
ret = snd_soc_dapm_new_controls(dapm, bridge_widgets,
5044
ARRAY_SIZE(bridge_widgets));
5145
if (ret) {

sound/soc/sdw_utils/soc_sdw_cs42l43.c

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -107,21 +107,11 @@ EXPORT_SYMBOL_NS(asoc_sdw_cs42l43_hs_rtd_init, "SND_SOC_SDW_UTILS");
107107

108108
int asoc_sdw_cs42l43_spk_rtd_init(struct snd_soc_pcm_runtime *rtd, struct snd_soc_dai *dai)
109109
{
110-
struct snd_soc_component *component = snd_soc_rtd_to_codec(rtd, 0)->component;
110+
struct snd_soc_component *component = dai->component;
111111
struct snd_soc_card *card = rtd->card;
112112
struct snd_soc_dapm_context *dapm = snd_soc_card_to_dapm(card);
113-
struct asoc_sdw_mc_private *ctx = snd_soc_card_get_drvdata(card);
114113
int ret;
115114

116-
if (!(ctx->mc_quirk & SOC_SDW_SIDECAR_AMPS)) {
117-
/* Will be set by the bridge code in this case */
118-
card->components = devm_kasprintf(card->dev, GFP_KERNEL,
119-
"%s spk:cs42l43-spk",
120-
card->components);
121-
if (!card->components)
122-
return -ENOMEM;
123-
}
124-
125115
ret = snd_soc_limit_volume(card, "cs42l43 Speaker Digital Volume",
126116
CS42L43_SPK_VOLUME_0DB);
127117
if (ret)

sound/soc/sdw_utils/soc_sdw_utils.c

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -758,6 +758,7 @@ struct asoc_sdw_codec_info codec_info_list[] = {
758758
{
759759
.direction = {true, false},
760760
.codec_name = "cs42l43-codec",
761+
.component_name = "cs42l43-spk",
761762
.dai_name = "cs42l43-dp6",
762763
.dai_type = SOC_SDW_DAI_TYPE_AMP,
763764
.dailink = {SOC_SDW_AMP_OUT_DAI_ID, SOC_SDW_UNUSED_DAI_ID},
@@ -1104,6 +1105,7 @@ static int asoc_sdw_find_codec_info_dai_index(const struct asoc_sdw_codec_info *
11041105
int asoc_sdw_rtd_init(struct snd_soc_pcm_runtime *rtd)
11051106
{
11061107
struct snd_soc_card *card = rtd->card;
1108+
struct asoc_sdw_mc_private *ctx = snd_soc_card_get_drvdata(card);
11071109
struct snd_soc_dapm_context *dapm = snd_soc_card_to_dapm(card);
11081110
struct asoc_sdw_codec_info *codec_info;
11091111
struct snd_soc_dai *dai;
@@ -1179,16 +1181,26 @@ int asoc_sdw_rtd_init(struct snd_soc_pcm_runtime *rtd)
11791181
/* Generate the spk component string for card->components string */
11801182
if (codec_info->dais[dai_index].dai_type == SOC_SDW_DAI_TYPE_AMP &&
11811183
codec_info->dais[dai_index].component_name) {
1184+
const char *component;
1185+
1186+
/*
1187+
* For the special case of cs42l43 with sidecar amps, use only
1188+
* "cs35l56-bridge" as the component name in card->components
1189+
*/
1190+
if (ctx->mc_quirk & SOC_SDW_SIDECAR_AMPS &&
1191+
!strcmp(codec_info->dais[dai_index].component_name, "cs42l43-spk"))
1192+
component = "cs35l56-bridge";
1193+
else
1194+
component = codec_info->dais[dai_index].component_name;
1195+
11821196
if (strlen (spk_components) == 0)
11831197
spk_components =
1184-
devm_kasprintf(card->dev, GFP_KERNEL, "%s",
1185-
codec_info->dais[dai_index].component_name);
1198+
devm_kasprintf(card->dev, GFP_KERNEL, "%s", component);
11861199
else
11871200
/* Append component name to spk_components */
11881201
spk_components =
11891202
devm_kasprintf(card->dev, GFP_KERNEL,
1190-
"%s+%s", spk_components,
1191-
codec_info->dais[dai_index].component_name);
1203+
"%s+%s", spk_components, component);
11921204
}
11931205

11941206
codec_info->dais[dai_index].rtd_init_done = true;

0 commit comments

Comments
 (0)