review: DRY telemetry param logic; inline hasTelemetryChange; trim README

Author: archandatta

README.md

@@ -221,9 +221,6 @@ Commands with JSON output support:
 - `kernel browsers get <id>` - Get detailed browser session info
   - `--output json`, `-o json` - Output raw JSON object
 - `kernel browsers update <id>` - Update a running browser session
-  - `--proxy-id <id>` - Set proxy; `--clear-proxy` to remove
-  - `--profile-id <id>` / `--profile-name <name>` - Load a profile; `--save-changes` to persist on exit
-  - `--viewport <WxH@fps>` - Resize viewport; `--force` to resize during active live view or recording
   - `--telemetry=all` to enable all categories; `--telemetry=off` to disable; `--telemetry=network=on,page=off` for per-category
   - `--output json`, `-o json` - Output raw JSON object
 - `kernel browsers curl <id> <url>` - Make HTTP requests through a browser session's Chrome network stack

cmd/browsers.go

@@ -425,16 +425,12 @@ func (b BrowsersCmd) Create(ctx context.Context, in BrowsersCreateInput) error {
 		}
 	}
 
-	if in.Telemetry == "all" {
-		params.Telemetry = kernel.BrowserTelemetryRequestConfigParam{Enabled: kernel.Opt(true)}
-	} else if in.Telemetry == "off" {
-		params.Telemetry = kernel.BrowserTelemetryRequestConfigParam{Enabled: kernel.Opt(false)}
-	} else if in.Telemetry != "" {
-		p, err := parseTelemetryCategories(in.Telemetry)
+	if in.Telemetry != "" {
+		t, err := applyTelemetryParam(in.Telemetry)
 		if err != nil {
 			return err
 		}
-		params.Telemetry = kernel.BrowserTelemetryRequestConfigParam{Enabled: kernel.Opt(true), Browser: p}
+		params.Telemetry = t
 	}
 
 	browser, err := b.browsers.New(ctx, params)
@@ -602,10 +598,8 @@ func (b BrowsersCmd) Update(ctx context.Context, in BrowsersUpdateInput) error {
 		return fmt.Errorf("--force requires --viewport")
 	}
 
-	hasTelemetryChange := in.Telemetry != ""
-
 	// Validate that at least one update option is provided
-	if !hasProxyChange && !hasProfileChange && !hasViewportChange && !hasTelemetryChange {
+	if !hasProxyChange && !hasProfileChange && !hasViewportChange && in.Telemetry == "" {
 		return fmt.Errorf("must specify at least one of: --proxy-id, --clear-proxy, --profile-id, --profile-name, --viewport, or --telemetry")
 	}
 
@@ -632,16 +626,12 @@ func (b BrowsersCmd) Update(ctx context.Context, in BrowsersUpdateInput) error {
 	}
 
 	// Handle telemetry changes
-	if in.Telemetry == "all" {
-		params.Telemetry = kernel.BrowserTelemetryRequestConfigParam{Enabled: kernel.Opt(true)}
-	} else if in.Telemetry == "off" {
-		params.Telemetry = kernel.BrowserTelemetryRequestConfigParam{Enabled: kernel.Opt(false)}
-	} else if in.Telemetry != "" {
-		p, err := parseTelemetryCategories(in.Telemetry)
+	if in.Telemetry != "" {
+		t, err := applyTelemetryParam(in.Telemetry)
 		if err != nil {
 			return err
 		}
-		params.Telemetry = kernel.BrowserTelemetryRequestConfigParam{Enabled: kernel.Opt(true), Browser: p}
+		params.Telemetry = t
 	}
 
 	// Handle viewport changes

cmd/browsers_telemetry.go

@@ -64,6 +64,22 @@ func parseTelemetryCategories(s string) (kernel.BrowserTelemetryCategoriesConfig
 	return p, nil
 }
 
+// applyTelemetryParam converts a --telemetry flag value to the API param.
+func applyTelemetryParam(s string) (kernel.BrowserTelemetryRequestConfigParam, error) {
+	switch s {
+	case "all":
+		return kernel.BrowserTelemetryRequestConfigParam{Enabled: kernel.Opt(true)}, nil
+	case "off":
+		return kernel.BrowserTelemetryRequestConfigParam{Enabled: kernel.Opt(false)}, nil
+	default:
+		p, err := parseTelemetryCategories(s)
+		if err != nil {
+			return kernel.BrowserTelemetryRequestConfigParam{}, err
+		}
+		return kernel.BrowserTelemetryRequestConfigParam{Enabled: kernel.Opt(true), Browser: p}, nil
+	}
+}
+
 // settableCategories are the categories accepted by --telemetry=<categories>.
 // "system" is always-on and cannot be toggled, but is valid as a --categories stream filter.
 var settableCategories = []string{"console", "interaction", "network", "page"}