fix: walk full window when telemetry events --types is set

The archive endpoint filters only by category server-side, so --types is
applied client-side after a page is fetched. In default (non --all) mode only
the first page was read, silently dropping matching events on later pages. Route
through the auto-pager whenever a type filter is active so results are complete.

Author: archandatta

README.md

@@ -325,7 +325,7 @@ Per-category updates are partial — only categories you name are changed; other
   - `--limit <n>` - Max events per page (1-100, default 20)
   - `--since <t>` / `--until <t>` - Window bounds as an RFC-3339 timestamp or a duration like `5m` (default window: last 5m)
   - `--categories <list>` - Filter by event category (`console`, `network`, `page`, `interaction`, `control`, `connection`, `system`, `screenshot`, `captcha`, `monitor`)
-  - `--types <list>` - Filter by event type (e.g. `network_response`, `console_error`)
+  - `--types <list>` - Filter by event type (e.g. `network_response`, `console_error`); filtered client-side, so this walks every page in the window for complete results
   - `--all` - Fetch every page in the window instead of just the first
   - `-o, --output json` - Output newline-delimited JSON envelopes
   - Default output: tab-separated `<time>\t<seq>\t[<category>]\t<type>`

cmd/browsers.go

@@ -2755,15 +2755,16 @@ followed automatically by Chromium.`,
 		Short: "Read recorded telemetry events",
 		Long: "Read recorded telemetry events for a browser session, in ascending sequence order.\n\n" +
 			"By default this returns the first page of events in the window (most recent window is the\n" +
-			"last 5m; adjust with --since/--until). Use --all to walk every page and dump the full archive.",
+			"last 5m; adjust with --since/--until). Use --all to walk every page and dump the full archive.\n\n" +
+			"--types filters client-side, so it walks every page in the window (like --all) to return complete results.",
 		Args: cobra.ExactArgs(1),
 		RunE: runBrowsersTelemetryEvents,
 	}
 	telemetryEvents.Flags().Int64("limit", 0, "Max events per page (1-100, default 20)")
 	telemetryEvents.Flags().String("since", "", "Window start: RFC-3339 timestamp or duration like 5m (default 5m)")
 	telemetryEvents.Flags().String("until", "", "Window end (exclusive): RFC-3339 timestamp or duration like 5m")
 	telemetryEvents.Flags().StringSlice("categories", []string{}, "Filter by event category (console,network,page,interaction,control,connection,system,screenshot,captcha,monitor)")
-	telemetryEvents.Flags().StringSlice("types", []string{}, "Filter by event type (e.g. network_response,console_error)")
+	telemetryEvents.Flags().StringSlice("types", []string{}, "Filter by event type (e.g. network_response,console_error); walks every page in the window")
 	telemetryEvents.Flags().Bool("all", false, "Fetch every page (the full archive in the window) instead of just the first")
 	telemetryEvents.Flags().StringP("output", "o", "", "Output format: json for newline-delimited JSON envelopes")
 	telemetryRoot.AddCommand(telemetryEvents)

cmd/browsers_telemetry.go

@@ -302,7 +302,11 @@ func (b BrowsersCmd) TelemetryEvents(ctx context.Context, in BrowsersTelemetryEv
 		return nil
 	}
 
-	if in.All {
+	// A --types filter is client-side (the archive endpoint filters only by
+	// category), so it must see every page to be complete: fetching a single page
+	// could drop matching events on later pages. Walk the whole window whenever a
+	// type filter is active, the same as --all.
+	if in.All || len(in.Types) > 0 {
 		pager := b.telemetry.EventsAutoPaging(ctx, sessionID, params, opts...)
 		for pager.Next() {
 			if err := emit(pager.Current()); err != nil {

cmd/browsers_telemetry_test.go

@@ -58,7 +58,7 @@ func (f *FakeBrowserTelemetryService) EventsAutoPaging(ctx context.Context, id s
 	if f.EventsAutoPagingFunc != nil {
 		return f.EventsAutoPagingFunc()
 	}
-	return nil
+	return pagination.NewOffsetPaginationAutoPager(&pagination.OffsetPagination[kernel.BrowserTelemetryEventsResponse]{}, nil)
 }
 
 func telemetryEventsPage(t *testing.T, raws ...string) *pagination.OffsetPagination[kernel.BrowserTelemetryEventsResponse] {
@@ -169,17 +169,25 @@ func TestTelemetryEvents_InvalidLimitErrors(t *testing.T) {
 	}
 }
 
-func TestTelemetryEvents_TypesFilterDropsNonMatching(t *testing.T) {
+// A --types filter is client-side, so it must scan every page in the window to be
+// complete. Setting --types (without --all) must therefore route through the
+// auto-pager, not the single-page fetch that could drop matches on later pages.
+func TestTelemetryEvents_TypesFilterWalksAllPages(t *testing.T) {
 	setupStdoutCapture(t)
 	fakeBrowsers := &FakeBrowsersService{GetFunc: func(ctx context.Context, id string, query kernel.BrowserGetParams, opts ...option.RequestOption) (*kernel.BrowserGetResponse, error) {
 		return &kernel.BrowserGetResponse{SessionID: id}, nil
 	}}
-	fakeTelemetry := &FakeBrowserTelemetryService{EventsFunc: func(id string, query kernel.BrowserTelemetryEventsParams, opts ...option.RequestOption) (*pagination.OffsetPagination[kernel.BrowserTelemetryEventsResponse], error) {
-		return telemetryEventsPage(t,
-			`{"event":{"type":"network_request","category":"network","ts":1000000},"seq":1}`,
-			`{"event":{"type":"network_response","category":"network","ts":2000000},"seq":2}`,
-		), nil
-	}}
+	autoPaged := false
+	fakeTelemetry := &FakeBrowserTelemetryService{
+		EventsFunc: func(id string, query kernel.BrowserTelemetryEventsParams, opts ...option.RequestOption) (*pagination.OffsetPagination[kernel.BrowserTelemetryEventsResponse], error) {
+			t.Fatalf("single-page Events must not be called when --types is set")
+			return nil, nil
+		},
+		EventsAutoPagingFunc: func() *pagination.OffsetPaginationAutoPager[kernel.BrowserTelemetryEventsResponse] {
+			autoPaged = true
+			return pagination.NewOffsetPaginationAutoPager(&pagination.OffsetPagination[kernel.BrowserTelemetryEventsResponse]{}, nil)
+		},
+	}
 	b := BrowsersCmd{browsers: fakeBrowsers, telemetry: fakeTelemetry}
 
 	err := b.TelemetryEvents(context.Background(), BrowsersTelemetryEventsInput{
@@ -188,8 +196,7 @@ func TestTelemetryEvents_TypesFilterDropsNonMatching(t *testing.T) {
 	})
 
 	assert.NoError(t, err)
-	assert.Contains(t, outBuf.String(), "network_response")
-	assert.NotContains(t, outBuf.String(), "network_request")
+	assert.True(t, autoPaged, "--types must walk every page so the client-side filter is complete")
 }
 
 func TestTelemetryEvents_FallsBackToIdentifierWhenGetFails(t *testing.T) {