review

Author: archandatta

cmd/extensions.go

@@ -320,17 +320,18 @@ func (e ExtensionsCmd) Upload(ctx context.Context, in ExtensionsUploadInput) err
 	}
 	defer os.Remove(tmpFile)
 
-	// Show helpful stats
+	// Get zip file size
+	fileInfo, err := os.Stat(tmpFile)
+	if err != nil {
+		return fmt.Errorf("failed to stat zip: %w", err)
+	}
+
 	if in.Output != "json" {
 		pterm.Success.Printf("Created bundle: %s (%d files)\n",
-			util.FormatBytes(stats.BytesIncluded), stats.FilesIncluded)
+			util.FormatBytes(fileInfo.Size()), stats.FilesIncluded)
 	}
 
 	// Final size validation
-	fileInfo, err := os.Stat(tmpFile)
-	if err != nil {
-		return fmt.Errorf("failed to stat zip: %w", err)
-	}
 
 	if fileInfo.Size() > MaxExtensionSize {
 		pterm.Error.Printf("Extension bundle is too large: %s (max: 50MB)\n",

pkg/util/zip_extensions.go

@@ -105,6 +105,9 @@ func ZipExtensionDirectory(srcDir, destZip string, opts *ExtensionZipOptions) (*
 		walker.ExcludeFilename = append(walker.ExcludeFilename, DefaultExtensionExclusions.ExcludeFilenamePatterns...)
 	}
 
+	// Ensure walker is terminated on any return path to prevent goroutine leak
+	defer walker.Terminate()
+
 	// Track walker errors
 	errChan := make(chan error, 1)
 	go func() {