Fail API key delete when key is missing

Author: IlyaasK

cmd/api_keys.go

@@ -192,8 +192,7 @@ func (c APIKeysCmd) Delete(ctx context.Context, in APIKeysDeleteInput) error {
 
 	if err := c.apiKeys.Delete(ctx, in.ID); err != nil {
 		if util.IsNotFound(err) {
-			pterm.Info.Printf("API key '%s' not found\n", in.ID)
-			return nil
+			return fmt.Errorf("API key %q not found", in.ID)
 		}
 		return util.CleanedUpSdkError{Err: err}
 	}

cmd/api_keys_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
+	"net/http"
 	"testing"
 
 	"github.com/kernel/kernel-go-sdk"
@@ -240,6 +241,20 @@ func TestAPIKeysDeleteSkipsConfirmation(t *testing.T) {
 	assert.Contains(t, buf.String(), "Deleted API key: key_123")
 }
 
+func TestAPIKeysDeleteReturnsNotFoundError(t *testing.T) {
+	fake := &FakeAPIKeysService{
+		DeleteFunc: func(ctx context.Context, id string, opts ...option.RequestOption) error {
+			assert.Equal(t, "missing_key", id)
+			return &kernel.Error{StatusCode: http.StatusNotFound}
+		},
+	}
+	c := APIKeysCmd{apiKeys: fake}
+
+	err := c.Delete(context.Background(), APIKeysDeleteInput{ID: "missing_key", SkipConfirm: true})
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), `API key "missing_key" not found`)
+}
+
 func TestAPIKeysDeleteReturnsAPIError(t *testing.T) {
 	fake := &FakeAPIKeysService{
 		DeleteFunc: func(ctx context.Context, id string, opts ...option.RequestOption) error {