fix: address bugbot review comments

- looksLikeCUID: require first character to be a letter (cuid2 spec)
- FakeProxyService.CheckFunc: update type signature and delegation to
  include body parameter

Made-with: Cursor

Author: hiroTamada

cmd/proxies/check_test.go

@@ -13,7 +13,7 @@ func TestProxyCheck_ShowsBypassHosts(t *testing.T) {
 	buf := captureOutput(t)
 
 	fake := &FakeProxyService{
-		CheckFunc: func(ctx context.Context, id string, opts ...option.RequestOption) (*kernel.ProxyCheckResponse, error) {
+		CheckFunc: func(ctx context.Context, id string, body kernel.ProxyCheckParams, opts ...option.RequestOption) (*kernel.ProxyCheckResponse, error) {
 			return &kernel.ProxyCheckResponse{
 				ID:          id,
 				Name:        "Proxy 1",

cmd/proxies/common_test.go

@@ -41,7 +41,7 @@ type FakeProxyService struct {
 	GetFunc    func(ctx context.Context, id string, opts ...option.RequestOption) (*kernel.ProxyGetResponse, error)
 	NewFunc    func(ctx context.Context, body kernel.ProxyNewParams, opts ...option.RequestOption) (*kernel.ProxyNewResponse, error)
 	DeleteFunc func(ctx context.Context, id string, opts ...option.RequestOption) error
-	CheckFunc  func(ctx context.Context, id string, opts ...option.RequestOption) (*kernel.ProxyCheckResponse, error)
+	CheckFunc  func(ctx context.Context, id string, body kernel.ProxyCheckParams, opts ...option.RequestOption) (*kernel.ProxyCheckResponse, error)
 }
 
 func (f *FakeProxyService) List(ctx context.Context, opts ...option.RequestOption) (*[]kernel.ProxyListResponse, error) {
@@ -75,7 +75,7 @@ func (f *FakeProxyService) Delete(ctx context.Context, id string, opts ...option
 
 func (f *FakeProxyService) Check(ctx context.Context, id string, body kernel.ProxyCheckParams, opts ...option.RequestOption) (*kernel.ProxyCheckResponse, error) {
 	if f.CheckFunc != nil {
-		return f.CheckFunc(ctx, id, opts...)
+		return f.CheckFunc(ctx, id, body, opts...)
 	}
 	return &kernel.ProxyCheckResponse{ID: id, Type: kernel.ProxyCheckResponseTypeDatacenter}, nil
 }

cmd/root.go

@@ -260,8 +260,12 @@ func looksLikeCUID(s string) bool {
 	if len(s) != 24 {
 		return false
 	}
-	for _, c := range s {
-		if !((c >= 'a' && c <= 'z') || (c >= '0' && c <= '9')) {
+	for i, c := range s {
+		if i == 0 {
+			if !(c >= 'a' && c <= 'z') {
+				return false
+			}
+		} else if !((c >= 'a' && c <= 'z') || (c >= '0' && c <= '9')) {
 			return false
 		}
 	}