Skip to content

Commit 161369f

Browse files
IlyaasKclaude
andcommitted
test: fix stale root-package allowlist assertions (telemetry/stream)
CI 'test' failed because two root-package assertions still referenced the old "telemetry" segment after the default allowlist changed to ["curl","telemetry/stream"]: - TestBrowserRoutingSubresourcesFromEnvDefaultsToCurl: default assertion - TestBrowserRoutingRewritesTelemetryStreamToVM: env override aligned to the full-path value it now exercises go test ./... passes. The lib/browserrouting matcher test already covers telemetry/events -> control plane. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 95487e0 commit 161369f

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

browser_routing_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func TestBrowserRoutingWarmsCacheAndRoutesAllowlistedSubresources(t *testing.T)
7272
}
7373

7474
func TestBrowserRoutingRewritesTelemetryStreamToVM(t *testing.T) {
75-
t.Setenv(browserRoutingSubresourcesEnv, "telemetry")
75+
t.Setenv(browserRoutingSubresourcesEnv, "telemetry/stream")
7676

7777
var calls []struct {
7878
Path string
@@ -189,8 +189,8 @@ func TestBrowserRoutingSubresourcesFromEnvDefaultsToCurl(t *testing.T) {
189189
}
190190
_ = os.Setenv(browserRoutingSubresourcesEnv, original)
191191
})
192-
if got := browserRoutingSubresourcesFromEnv(); len(got) != 2 || got[0] != "curl" || got[1] != "telemetry" {
193-
t.Fatalf("expected default subresources [curl telemetry], got %#v", got)
192+
if got := browserRoutingSubresourcesFromEnv(); len(got) != 2 || got[0] != "curl" || got[1] != "telemetry/stream" {
193+
t.Fatalf("expected default subresources [curl telemetry/stream], got %#v", got)
194194
}
195195

196196
t.Setenv(browserRoutingSubresourcesEnv, "")

0 commit comments

Comments
 (0)