Skip to content

Commit 47c6dc5

Browse files
authored
Merge pull request #73 from kernel/mason/cli-coverage-testing
Add live smoke testing to CLI coverage workflow
2 parents f817833 + fd4f331 commit 47c6dc5

1 file changed

Lines changed: 24 additions & 1 deletion

File tree

.github/workflows/update-cli-coverage.yml

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ jobs:
141141
env:
142142
CURSOR_API_KEY: ${{ secrets.CURSOR_API_KEY }}
143143
GH_TOKEN: ${{ steps.app-token.outputs.token }}
144+
KERNEL_API_KEY: ${{ secrets.KERNEL_API_KEY }}
144145
BRANCH_PREFIX: cli-coverage-update
145146
run: |
146147
cursor-agent -p "You are a CLI updater that implements missing CLI commands based on SDK updates.
@@ -232,10 +233,32 @@ jobs:
232233
- Add missing flags to existing commands
233234
- Run \`go build ./...\` to verify the code compiles
234235
235-
## Step 6: Commit and Push
236+
## Step 6: Test Your Changes (ALWAYS DO THIS)
237+
After implementing, build the CLI and smoke test the new commands/flags you just added against the real API.
238+
The KERNEL_API_KEY environment variable is available for authentication.
239+
240+
6a. Build the CLI:
241+
cd /tmp/kernel-cli && go build -o /tmp/kernel-cli/bin/kernel ./cmd/kernel
242+
243+
6b. For each new command or flag you added:
244+
- Run the command against the real API and verify it succeeds
245+
- For create/write commands: create a resource, verify it works, then clean up (delete it)
246+
- For read commands: call them and verify the output format is correct
247+
- For flag additions: create a resource with the new flag and verify it shows up in the get output
248+
Example test flow for a new browser flag:
249+
/tmp/kernel-cli/bin/kernel browsers create --new-flag value -t 30
250+
/tmp/kernel-cli/bin/kernel browsers get <id> # verify new-flag appears
251+
/tmp/kernel-cli/bin/kernel browsers delete <id> # clean up
252+
253+
6c. If any command fails or produces unexpected output, fix the implementation and re-test before proceeding.
254+
255+
6d. If you added no new commands or flags (SDK version bump only), skip this step.
256+
257+
## Step 7: Commit and Push
236258
- You should already be on the cli-coverage-update branch (it was checked out during setup if it existed)
237259
- If you're on main, create/switch to the cli-coverage-update branch
238260
- Commit with message describing SDK version bump and any new commands/flags
261+
- Include test results in the commit message (e.g., 'Tested: browsers create --gpu, browsers computer get-mouse-position')
239262
- IMPORTANT: Do NOT force push! Use regular \`git push origin cli-coverage-update\` to preserve existing work on the branch
240263
- If push fails due to divergence, pull and rebase first: \`git pull --rebase origin cli-coverage-update\`
241264
- Create or update the PR in kernel/cli

0 commit comments

Comments
 (0)