Rename API paths to /scaletozero/{disable,enable}

Match user-facing terminology to the action ("disable scale to zero")
rather than the internal pin mechanism. Internal PinnedController.Pin/Unpin
methods retain pin/unpin naming since they're distinct from the refcounted
Controller.Disable/Enable.

Author: sjmiller609

server/cmd/api/api/scaletozero.go

@@ -7,18 +7,18 @@ import (
 	oapi "github.com/kernel/kernel-images/server/lib/oapi"
 )
 
-func (s *ApiService) PinScaleToZero(ctx context.Context, _ oapi.PinScaleToZeroRequestObject) (oapi.PinScaleToZeroResponseObject, error) {
+func (s *ApiService) DisableScaleToZero(ctx context.Context, _ oapi.DisableScaleToZeroRequestObject) (oapi.DisableScaleToZeroResponseObject, error) {
 	if err := s.stz.Pin(ctx); err != nil {
-		logger.FromContext(ctx).Error("failed to pin scale-to-zero", "err", err)
-		return oapi.PinScaleToZero500JSONResponse{InternalErrorJSONResponse: oapi.InternalErrorJSONResponse{Message: "failed to pin scale-to-zero"}}, nil
+		logger.FromContext(ctx).Error("failed to disable scale-to-zero", "err", err)
+		return oapi.DisableScaleToZero500JSONResponse{InternalErrorJSONResponse: oapi.InternalErrorJSONResponse{Message: "failed to disable scale-to-zero"}}, nil
 	}
-	return oapi.PinScaleToZero204Response{}, nil
+	return oapi.DisableScaleToZero204Response{}, nil
 }
 
-func (s *ApiService) UnpinScaleToZero(ctx context.Context, _ oapi.UnpinScaleToZeroRequestObject) (oapi.UnpinScaleToZeroResponseObject, error) {
+func (s *ApiService) EnableScaleToZero(ctx context.Context, _ oapi.EnableScaleToZeroRequestObject) (oapi.EnableScaleToZeroResponseObject, error) {
 	if err := s.stz.Unpin(ctx); err != nil {
-		logger.FromContext(ctx).Error("failed to unpin scale-to-zero", "err", err)
-		return oapi.UnpinScaleToZero500JSONResponse{InternalErrorJSONResponse: oapi.InternalErrorJSONResponse{Message: "failed to unpin scale-to-zero"}}, nil
+		logger.FromContext(ctx).Error("failed to enable scale-to-zero", "err", err)
+		return oapi.EnableScaleToZero500JSONResponse{InternalErrorJSONResponse: oapi.InternalErrorJSONResponse{Message: "failed to enable scale-to-zero"}}, nil
 	}
-	return oapi.UnpinScaleToZero204Response{}, nil
+	return oapi.EnableScaleToZero204Response{}, nil
 }

server/e2e/e2e_scaletozero_test.go

@@ -10,12 +10,12 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-// TestScaleToZeroPinUnpin exercises POST /scaletozero/{pin,unpin} against the
-// real built image. The unikraft control file does not exist inside the docker
-// test container, so the underlying scale-to-zero write is a no-op — this test
-// validates HTTP wiring, idempotency, and that the scale-to-zero middleware
-// coexists with the pin handlers.
-func TestScaleToZeroPinUnpin(t *testing.T) {
+// TestScaleToZeroDisableEnable exercises POST /scaletozero/{disable,enable}
+// against the real built image. The unikraft control file does not exist
+// inside the docker test container, so the underlying scale-to-zero write is
+// a no-op — this test validates HTTP wiring, idempotency, and that the
+// scale-to-zero middleware coexists with the disable/enable handlers.
+func TestScaleToZeroDisableEnable(t *testing.T) {
 	t.Parallel()
 
 	if _, err := exec.LookPath("docker"); err != nil {
@@ -34,27 +34,27 @@ func TestScaleToZeroPinUnpin(t *testing.T) {
 	client, err := c.APIClient()
 	require.NoError(t, err, "failed to create API client")
 
-	// Idempotent pin.
-	r1, err := client.PinScaleToZeroWithResponse(ctx)
-	require.NoError(t, err, "PinScaleToZero request failed")
+	// Idempotent disable.
+	r1, err := client.DisableScaleToZeroWithResponse(ctx)
+	require.NoError(t, err, "DisableScaleToZero request failed")
 	require.Equal(t, http.StatusNoContent, r1.StatusCode(), "unexpected status: %s body=%s", r1.Status(), string(r1.Body))
 
-	r2, err := client.PinScaleToZeroWithResponse(ctx)
-	require.NoError(t, err, "second PinScaleToZero request failed")
+	r2, err := client.DisableScaleToZeroWithResponse(ctx)
+	require.NoError(t, err, "second DisableScaleToZero request failed")
 	require.Equal(t, http.StatusNoContent, r2.StatusCode(), "unexpected status: %s body=%s", r2.Status(), string(r2.Body))
 
-	// Normal request must still flow while pinned (scaletozero middleware
+	// Normal request must still flow while disabled (scaletozero middleware
 	// runs on every request — the pin must not deadlock or break it).
 	readResp, err := client.ReadClipboardWithResponse(ctx)
-	require.NoError(t, err, "ReadClipboard request failed while pinned")
-	require.Equal(t, http.StatusOK, readResp.StatusCode(), "unexpected read status while pinned: %s body=%s", readResp.Status(), string(readResp.Body))
+	require.NoError(t, err, "ReadClipboard request failed while disabled")
+	require.Equal(t, http.StatusOK, readResp.StatusCode(), "unexpected read status while disabled: %s body=%s", readResp.Status(), string(readResp.Body))
 
-	// Idempotent unpin.
-	r3, err := client.UnpinScaleToZeroWithResponse(ctx)
-	require.NoError(t, err, "UnpinScaleToZero request failed")
+	// Idempotent enable.
+	r3, err := client.EnableScaleToZeroWithResponse(ctx)
+	require.NoError(t, err, "EnableScaleToZero request failed")
 	require.Equal(t, http.StatusNoContent, r3.StatusCode(), "unexpected status: %s body=%s", r3.Status(), string(r3.Body))
 
-	r4, err := client.UnpinScaleToZeroWithResponse(ctx)
-	require.NoError(t, err, "second UnpinScaleToZero request failed")
+	r4, err := client.EnableScaleToZeroWithResponse(ctx)
+	require.NoError(t, err, "second EnableScaleToZero request failed")
 	require.Equal(t, http.StatusNoContent, r4.StatusCode(), "unexpected status: %s body=%s", r4.Status(), string(r4.Body))
 }