Skip to content

Commit 6e0ae57

Browse files
committed
refactor: remove WebRTCRelayEnabled config, always register endpoint
The relay is lazy-started on first request so there's no cost to always registering the /display/webrtc endpoint. No need for a config toggle. Made-with: Cursor
1 parent 7513872 commit 6e0ae57

2 files changed

Lines changed: 10 additions & 18 deletions

File tree

server/cmd/api/main.go

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -140,21 +140,17 @@ func main() {
140140
// the VP8 video stream to external WebRTC clients via a single
141141
// WebSocket signaling endpoint. The Neko connection is lazy —
142142
// it only starts when the first client connects.
143-
if config.WebRTCRelayEnabled {
144-
relay, err := webrtcscreen.NewRelay(ctx, webrtcscreen.RelayConfig{
145-
NekoBaseURL: "http://127.0.0.1:8080",
146-
NekoUser: "admin",
147-
NekoPass: adminPassword,
148-
Logger: slogger,
149-
})
150-
if err != nil {
151-
slogger.Error("failed to create webrtc relay", "err", err)
152-
os.Exit(1)
153-
}
154-
155-
r.Get("/display/webrtc", relay.HandleWebSocket)
156-
slogger.Info("webrtc relay endpoint registered at /display/webrtc (lazy start)")
143+
relay, err := webrtcscreen.NewRelay(ctx, webrtcscreen.RelayConfig{
144+
NekoBaseURL: "http://127.0.0.1:8080",
145+
NekoUser: "admin",
146+
NekoPass: adminPassword,
147+
Logger: slogger,
148+
})
149+
if err != nil {
150+
slogger.Error("failed to create webrtc relay", "err", err)
151+
os.Exit(1)
157152
}
153+
r.Get("/display/webrtc", relay.HandleWebSocket)
158154

159155
srv := &http.Server{
160156
Addr: fmt.Sprintf(":%d", config.Port),

server/cmd/config/config.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ type Config struct {
2222

2323
// DevTools proxy configuration
2424
LogCDPMessages bool `envconfig:"LOG_CDP_MESSAGES" default:"false"`
25-
26-
// WebRTC relay: connects to Neko internally and re-serves the video
27-
// stream to external WebRTC clients via /display/webrtc.
28-
WebRTCRelayEnabled bool `envconfig:"WEBRTC_RELAY_ENABLED" default:"true"`
2925
}
3026

3127
// Load loads configuration from environment variables

0 commit comments

Comments
 (0)