review: remove DroppedFrom/DroppedTo fields and trim redundant comments

Author: archandatta

server/lib/events/eventsstorage.go

@@ -80,7 +80,7 @@ func (w *StorageWriter) Drain(ctx context.Context) error {
 
 func (w *StorageWriter) processResult(ctx context.Context, res ReadResult) error {
 	if res.Dropped > 0 {
-		w.log.Warn("storage writer: dropped events", "count", res.Dropped, "from_seq", res.DroppedFrom, "to_seq", res.DroppedTo)
+		w.log.Warn("storage writer: dropped events", "count", res.Dropped)
 		return nil
 	}
 	if err := w.storage.Append(ctx, *res.Envelope); err != nil {

server/lib/events/ringbuffer.go

@@ -68,13 +68,10 @@ func (rb *ringBuffer) newReader(afterSeq uint64) *Reader {
 
 // ReadResult is returned by Reader.Read. Exactly one of Envelope or Dropped is
 // set: Envelope is non-nil for a normal read, Dropped is non-zero when the
-// reader fell behind and events were lost. When Dropped > 0, DroppedFrom and
-// DroppedTo are the inclusive seq range of the dropped events.
+// reader fell behind and events were lost.
 type ReadResult struct {
-	Envelope    *Envelope
-	Dropped     uint64
-	DroppedFrom uint64 // first seq of the dropped range (only valid when Dropped > 0)
-	DroppedTo   uint64 // last seq of the dropped range (only valid when Dropped > 0)
+	Envelope *Envelope
+	Dropped  uint64
 }
 
 // Reader tracks an independent read position in a ringBuffer.
@@ -98,10 +95,9 @@ func (r *Reader) TryRead() (ReadResult, bool) {
 	}
 
 	if r.nextSeq < oldest {
-		from := r.nextSeq
 		dropped := oldest - r.nextSeq
 		r.nextSeq = oldest
-		return ReadResult{Dropped: dropped, DroppedFrom: from, DroppedTo: oldest - 1}, true
+		return ReadResult{Dropped: dropped}, true
 	}
 
 	env := r.rb.buf[r.nextSeq%r.rb.cap]
@@ -131,11 +127,10 @@ func (r *Reader) Read(ctx context.Context) (ReadResult, error) {
 		}
 
 		if r.nextSeq < oldest {
-			from := r.nextSeq
 			dropped := oldest - r.nextSeq
 			r.nextSeq = oldest
 			r.rb.mu.RUnlock()
-			return ReadResult{Dropped: dropped, DroppedFrom: from, DroppedTo: oldest - 1}, nil
+			return ReadResult{Dropped: dropped}, nil
 		}
 
 		if r.nextSeq <= latest {

server/lib/events/s2storage.go

@@ -11,7 +11,6 @@ import (
 	"github.com/s2-streamstore/s2-sdk-go/s2"
 )
 
-// S2Config holds batcher tuning parameters for the S2 backend.
 type S2Config struct {
 	// BatcherLinger is how long the batcher waits before flushing (default: 100ms).
 	BatcherLinger time.Duration
@@ -38,16 +37,14 @@ func (sp *s2Producer) close(ctx context.Context) error {
 	return sp.p.Close()
 }
 
-// S2Storage is a Storage backed by S2. All events are appended to a single
-// fixed stream whose name is provided at construction time.
+// S2Storage appends all events to a single fixed stream set at construction time.
 type S2Storage struct {
 	producer   s2Producer
 	shutdownCh chan struct{} // closed when Close is called, bounds ack goroutine contexts
 	log        *slog.Logger
 }
 
-// NewS2Storage creates an S2Storage that appends to the given stream within basin.
-// ctx is used for AppendSession creation and should be the process lifetime context.
+// ctx is used for AppendSession creation and must be the process lifetime context.
 func NewS2Storage(ctx context.Context, basin, accessToken, streamName string, cfg S2Config, log *slog.Logger) (*S2Storage, error) {
 	if basin == "" || accessToken == "" || streamName == "" {
 		return nil, fmt.Errorf("s2storage: basin, accessToken, and streamName are required")
@@ -74,7 +71,6 @@ func NewS2Storage(ctx context.Context, basin, accessToken, streamName string, cf
 	}, nil
 }
 
-// Append marshals env to JSON and submits it to the S2 producer.
 func (s *S2Storage) Append(_ context.Context, env Envelope) error {
 	data, err := json.Marshal(env)
 	if err != nil {