Fix PR 112 review follow-ups

Resolve the active Cursor profile pagination bug by preserving structured JSON for explicit empty pages, restore the cleaner computer_action structure from main with clipboard support, derive browser config payload types from the SDK, and remove stale dead types.

Author: IlyaasK

src/lib/mcp/browser-config.ts

@@ -1,3 +1,16 @@
+import type { KernelClient } from "@/lib/mcp/kernel-client";
+
+type BrowserCreateParams = NonNullable<
+  Parameters<KernelClient["browsers"]["create"]>[0]
+>;
+type BrowserUpdateParams = Parameters<KernelClient["browsers"]["update"]>[1];
+type BrowserPoolCreateParams = Parameters<
+  KernelClient["browserPools"]["create"]
+>[0];
+type BrowserPoolUpdateParams = Parameters<
+  KernelClient["browserPools"]["update"]
+>[1];
+
 export type BrowserProfileParams = {
   profile_name?: string;
   profile_id?: string;
@@ -28,36 +41,36 @@ export type BrowserCreateConfigParams = BrowserProfileParams &
 export type BrowserUpdateConfigParams = BrowserProfileParams &
   BrowserViewportUpdateParams;
 
-type BrowserProfileConfig = {
-  id?: string;
-  name?: string;
-  save_changes?: boolean;
-};
-
-type BrowserExtensionConfig = Array<{
-  id?: string;
-  name?: string;
-}>;
-
-type BrowserViewportConfig = {
-  width: number;
-  height: number;
-  refresh_rate?: number;
-};
-
-type BrowserViewportUpdateConfig = BrowserViewportConfig & { force?: boolean };
-
-export type BrowserCreateConfig = {
-  profile?: BrowserProfileConfig;
-  extensions?: BrowserExtensionConfig;
-  viewport?: BrowserViewportConfig;
-  start_url?: string;
-};
-
-export type BrowserUpdateConfig = {
-  profile?: BrowserProfileConfig;
-  viewport?: BrowserViewportUpdateConfig;
-};
+type BrowserProfileConfig = NonNullable<
+  | BrowserCreateParams["profile"]
+  | BrowserUpdateParams["profile"]
+  | BrowserPoolCreateParams["profile"]
+  | BrowserPoolUpdateParams["profile"]
+>;
+
+type BrowserExtensionConfig = NonNullable<
+  | BrowserCreateParams["extensions"]
+  | BrowserPoolCreateParams["extensions"]
+  | BrowserPoolUpdateParams["extensions"]
+>;
+
+type BrowserViewportConfig = NonNullable<
+  | BrowserCreateParams["viewport"]
+  | BrowserPoolCreateParams["viewport"]
+  | BrowserPoolUpdateParams["viewport"]
+>;
+
+type BrowserViewportUpdateConfig = NonNullable<BrowserUpdateParams["viewport"]>;
+
+export type BrowserCreateConfig = Pick<
+  BrowserCreateParams,
+  "profile" | "extensions" | "viewport" | "start_url"
+>;
+
+export type BrowserUpdateConfig = Pick<
+  BrowserUpdateParams,
+  "profile" | "viewport"
+>;
 
 export type BrowserConfigResult<T> =
   | { ok: true; value: T }

src/lib/mcp/responses.ts

@@ -10,6 +10,11 @@ type PaginatedJsonResponseOptions<T, U = T> = {
   emptyText?: string;
 };
 
+type ItemsJsonResponseOptions<T, U = T> = PaginatedJsonResponseOptions<T, U> & {
+  has_more?: boolean | null;
+  next_offset?: number | null;
+};
+
 export function textResponse(text: string) {
   return { content: [{ type: "text" as const, text }] };
 }
@@ -18,20 +23,30 @@ export function jsonResponse(value: unknown) {
   return textResponse(JSON.stringify(value, null, 2) ?? String(value));
 }
 
-export function paginatedJsonResponse<T, U = T>(
-  page: PaginatedPage<T>,
-  options: PaginatedJsonResponseOptions<T, U> = {},
+export function itemsJsonResponse<T, U = T>(
+  items: T[],
+  options: ItemsJsonResponseOptions<T, U> = {},
 ) {
-  const items = page.getPaginatedItems();
   if (items.length === 0 && options.emptyText) {
     return textResponse(options.emptyText);
   }
 
   return jsonResponse({
     items: options.mapItem ? items.map(options.mapItem) : items,
+    has_more: options.has_more,
+    next_offset: options.next_offset,
+    ...(options.note && { note: options.note }),
+  });
+}
+
+export function paginatedJsonResponse<T, U = T>(
+  page: PaginatedPage<T>,
+  options: PaginatedJsonResponseOptions<T, U> = {},
+) {
+  return itemsJsonResponse(page.getPaginatedItems(), {
+    ...options,
     has_more: page.has_more,
     next_offset: page.next_offset,
-    ...(options.note && { note: options.note }),
   });
 }
 

src/lib/mcp/tools/browser-pools.ts

@@ -27,16 +27,6 @@ type BrowserPoolAcquireResponse = Awaited<
   ReturnType<KernelClient["browserPools"]["acquire"]>
 >;
 
-type BrowserPoolAction =
-  | "create"
-  | "update"
-  | "list"
-  | "get"
-  | "delete"
-  | "flush"
-  | "acquire"
-  | "release";
-
 type PoolConfigParams = BrowserCreateConfigParams & {
   size?: number;
   name?: string;

src/lib/mcp/tools/browsers.ts

@@ -29,8 +29,6 @@ type TelemetryParams = {
   telemetry_interaction?: boolean;
 };
 
-type BrowserAction = "create" | "update" | "list" | "get" | "delete";
-
 const telemetryCategories = [
   ["telemetry_console", "console"],
   ["telemetry_network", "network"],
@@ -342,8 +340,12 @@ export function registerBrowserCapabilities(server: McpServer) {
               createParams.timeout_seconds = params.timeout_seconds;
             if (params.kiosk_mode !== undefined)
               createParams.kiosk_mode = params.kiosk_mode;
-            if (params.chrome_policy)
+            if (
+              params.chrome_policy &&
+              Object.keys(params.chrome_policy).length > 0
+            ) {
               createParams.chrome_policy = params.chrome_policy;
+            }
             if (params.proxy_id) createParams.proxy_id = params.proxy_id;
             const browserConfig = buildBrowserCreateConfig(params);
             if (!browserConfig.ok) return errorResponse(browserConfig.error);