Skip to content

Commit 2f16386

Browse files
committed
fix: drop node browser routing branch churn
Remove the unnecessary generated resource and dependency diffs from the node branch and keep BrowserRouteCache.set() as a direct assignment without trimming user input. Made-with: Cursor
1 parent b09434e commit 2f16386

5 files changed

Lines changed: 4 additions & 73 deletions

File tree

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
"prettier": "^3.0.0",
4646
"publint": "^0.2.12",
4747
"ts-jest": "^29.1.0",
48-
"ts-morph": "^28.0.0",
4948
"ts-node": "^10.5.0",
5049
"tsc-multi": "https://github.com/stainless-api/tsc-multi/releases/download/v1.1.9/tsc-multi.tgz",
5150
"tsconfig-paths": "^4.0.0",

src/lib/browser-routing.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,7 @@ export class BrowserRouteCache {
3030
}
3131

3232
set(route: BrowserRoute): void {
33-
this.entries.set(route.sessionId, {
34-
sessionId: route.sessionId.trim(),
35-
baseURL: route.baseURL.trim(),
36-
jwt: route.jwt.trim(),
37-
});
33+
this.entries.set(route.sessionId, route);
3834
}
3935

4036
delete(sessionId: string): void {

src/resources/browser-pools.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ export interface BrowserPoolAcquireResponse {
306306
webdriver_ws_url: string;
307307

308308
/**
309-
* HTTP base URL for routing browser subresource requests to this session's browser VM.
309+
* Metro-API HTTP base URL for this browser session.
310310
*/
311311
base_url?: string;
312312

src/resources/invocations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ export namespace InvocationListBrowsersResponse {
454454
webdriver_ws_url: string;
455455

456456
/**
457-
* HTTP base URL for routing browser subresource requests to this session's browser VM.
457+
* Metro-API HTTP base URL for this browser session.
458458
*/
459459
base_url?: string;
460460

yarn.lock

Lines changed: 1 addition & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -828,15 +828,6 @@
828828
dependencies:
829829
"@swc/counter" "^0.1.3"
830830

831-
"@ts-morph/common@~0.29.0":
832-
version "0.29.0"
833-
resolved "https://registry.yarnpkg.com/@ts-morph/common/-/common-0.29.0.tgz#bb1ed737f309c8270bb2e92207066343c1302ae2"
834-
integrity sha512-35oUmphHbJvQ/+UTwFNme/t2p3FoKiGJ5auTjjpNTop2dyREspirjMy82PLSC1pnDJ8ah1GU98hwpVt64YXQsg==
835-
dependencies:
836-
minimatch "^10.0.1"
837-
path-browserify "^1.0.1"
838-
tinyglobby "^0.2.14"
839-
840831
"@tsconfig/node10@^1.0.7":
841832
version "1.0.8"
842833
resolved "https://registry.yarnpkg.com/@tsconfig/node10/-/node10-1.0.8.tgz#c1e4e80d6f964fbecb3359c43bd48b40f7cadad9"
@@ -890,13 +881,6 @@
890881
dependencies:
891882
"@babel/types" "^7.20.7"
892883

893-
"@types/busboy@^1.5.4":
894-
version "1.5.4"
895-
resolved "https://registry.yarnpkg.com/@types/busboy/-/busboy-1.5.4.tgz#0038c31102ca90f2a7f0d8bc27ee5ebf1088e230"
896-
integrity sha512-kG7WrUuAKK0NoyxfQHsVE6j1m01s6kMma64E+OZenQABMQyTJop1DumUWcLwAQ2JzpefU7PDYoRDKl8uZosFjw==
897-
dependencies:
898-
"@types/node" "*"
899-
900884
"@types/estree@^1.0.6":
901885
version "1.0.6"
902886
resolved "https://registry.yarnpkg.com/@types/estree/-/estree-1.0.6.tgz#628effeeae2064a1b4e79f78e81d87b7e5fc7b50"
@@ -1279,13 +1263,6 @@ buffer-from@^1.0.0:
12791263
resolved "https://registry.yarnpkg.com/buffer-from/-/buffer-from-1.1.2.tgz#2b146a6fd72e80b4f55d255f35ed59a3a9a41bd5"
12801264
integrity sha512-E+XQCRwSbaaiChtv6k6Dwgc+bx+Bs6vuKJHHl5kox/BaKbhiXzqQOwK4cO22yElGp2OCmjwVhT3HmxgyPGnJfQ==
12811265

1282-
busboy@^1.6.0:
1283-
version "1.6.0"
1284-
resolved "https://registry.yarnpkg.com/busboy/-/busboy-1.6.0.tgz#966ea36a9502e43cdb9146962523b92f531f6893"
1285-
integrity sha512-8SFQbg/0hQ9xy3UNTB0YEnsNBbWfhf7RtnzpL7TkBiTBRfrQ9Fxcnz7VJsleJpyp6rVLvXiuORqjlHi5q+PYuA==
1286-
dependencies:
1287-
streamsearch "^1.1.0"
1288-
12891266
callsites@^3.0.0:
12901267
version "3.1.0"
12911268
resolved "https://registry.yarnpkg.com/callsites/-/callsites-3.1.0.tgz#b3630abd8943432f54b3f0519238e33cd7df2f73"
@@ -1388,11 +1365,6 @@ co@^4.6.0:
13881365
resolved "https://registry.yarnpkg.com/co/-/co-4.6.0.tgz#6ea6bdf3d853ae54ccb8e47bfa0bf3f9031fb184"
13891366
integrity sha512-QVb0dM5HvG+uaxitm8wONl7jltx8dqhfU33DcqtOZcLSVIKSDDLDi7+0LbAKiyI8hD9u42m2YxXSkMGWThaecQ==
13901367

1391-
code-block-writer@^13.0.3:
1392-
version "13.0.3"
1393-
resolved "https://registry.yarnpkg.com/code-block-writer/-/code-block-writer-13.0.3.tgz#90f8a84763a5012da7af61319dd638655ae90b5b"
1394-
integrity sha512-Oofo0pq3IKnsFtuHqSF7TqBfr71aeyZDVJ0HpmqB7FBM2qEigL0iPONSCZSO9pE9dZTAxANe5XHG9Uy0YMv8cg==
1395-
13961368
collect-v8-coverage@^1.0.0:
13971369
version "1.0.2"
13981370
resolved "https://registry.yarnpkg.com/collect-v8-coverage/-/collect-v8-coverage-1.0.2.tgz#c0b29bcd33bcd0779a1344c2136051e6afd3d9e9"
@@ -1742,11 +1714,6 @@ fb-watchman@^2.0.0:
17421714
dependencies:
17431715
bser "2.1.1"
17441716

1745-
fdir@^6.5.0:
1746-
version "6.5.0"
1747-
resolved "https://registry.yarnpkg.com/fdir/-/fdir-6.5.0.tgz#ed2ab967a331ade62f18d077dae192684d50d350"
1748-
integrity sha512-tIbYtZbucOs0BRGqPJkshJUYdL+SDH7dVM8gjy+ERp3WAUjLEFJE+02kanyHtwjWOnwrKYBiwAmM0p4kLJAnXg==
1749-
17501717
fflate@^0.8.2:
17511718
version "0.8.2"
17521719
resolved "https://registry.yarnpkg.com/fflate/-/fflate-0.8.2.tgz#fc8631f5347812ad6028bbe4a2308b2792aa1dea"
@@ -2620,7 +2587,7 @@ mimic-fn@^2.1.0:
26202587
resolved "https://registry.yarnpkg.com/mimic-fn/-/mimic-fn-2.1.0.tgz#7ed2c2ccccaf84d3ffcb7a69b57711fc2083401b"
26212588
integrity sha512-OqbOk5oEQeAZ8WXWydlu9HJjz9WVdEIvamMCcXmuqUYjTknH/sqsWvhQ3vgwKFRR1HpjvNBKQ37nbJgYzGqGcg==
26222589

2623-
minimatch@^10.0.1, minimatch@^3.0.4, minimatch@^3.1.1, minimatch@^3.1.2, minimatch@^5.0.1, minimatch@^9.0.4, minimatch@^9.0.5:
2590+
minimatch@^3.0.4, minimatch@^3.1.1, minimatch@^3.1.2, minimatch@^5.0.1, minimatch@^9.0.4, minimatch@^9.0.5:
26242591
version "9.0.9"
26252592
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-9.0.9.tgz#9b0cb9fcb78087f6fd7eababe2511c4d3d60574e"
26262593
integrity sha512-OBwBN9AL4dqmETlpS2zasx+vTeWclWzkblfZk7KTA5j3jeOONz/tRCnZomUyvNg83wL5Zv9Ss6HMJXAgL8R2Yg==
@@ -2827,11 +2794,6 @@ parse5@^6.0.1:
28272794
resolved "https://registry.yarnpkg.com/parse5/-/parse5-6.0.1.tgz#e1a1c085c569b3dc08321184f19a39cc27f7c30b"
28282795
integrity sha512-Ofn/CTFzRGTTxwpNEs9PP93gXShHcTq255nzRYSKe8AkVpZY7e1fpmTfOyoIvjP5HG7Z2ZM7VS9PPhQGW2pOpw==
28292796

2830-
path-browserify@^1.0.1:
2831-
version "1.0.1"
2832-
resolved "https://registry.yarnpkg.com/path-browserify/-/path-browserify-1.0.1.tgz#d98454a9c3753d5790860f16f68867b9e46be1fd"
2833-
integrity sha512-b7uo2UCUOYZcnF/3ID0lulOJi/bafxa1xPe7ZPsammBSpjSWQkjNxlt635YGS2MiR9GjvuXCtz2emr3jbsz98g==
2834-
28352797
path-exists@^4.0.0:
28362798
version "4.0.0"
28372799
resolved "https://registry.yarnpkg.com/path-exists/-/path-exists-4.0.0.tgz#513bdbe2d3b95d7762e8c1137efa195c6c61b5b3"
@@ -2862,11 +2824,6 @@ picomatch@^2.0.4, picomatch@^2.2.3, picomatch@^2.3.1:
28622824
resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.3.1.tgz#3ba3833733646d9d3e4995946c1365a67fb07a42"
28632825
integrity sha512-JU3teHTNjmE2VCGFzuY8EXzCDVwEqB2a8fsIvwaStHhAWJEeVd1o1QD80CU6+ZdEXXSLbSsuLwJjkCBWqRQUVA==
28642826

2865-
picomatch@^4.0.4:
2866-
version "4.0.4"
2867-
resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-4.0.4.tgz#fd6f5e00a143086e074dffe4c924b8fb293b0589"
2868-
integrity sha512-QP88BAKvMam/3NxH6vj2o21R6MjxZUAd6nlwAS/pnGvN9IVLocLHxGYIzFhg6fUQ+5th6P4dv4eW9jX3DSIj7A==
2869-
28702827
pirates@^4.0.4:
28712828
version "4.0.6"
28722829
resolved "https://registry.yarnpkg.com/pirates/-/pirates-4.0.6.tgz#3018ae32ecfcff6c29ba2267cbf21166ac1f36b9"
@@ -3097,11 +3054,6 @@ stack-utils@^2.0.3:
30973054
dependencies:
30983055
escape-string-regexp "^2.0.0"
30993056

3100-
streamsearch@^1.1.0:
3101-
version "1.1.0"
3102-
resolved "https://registry.yarnpkg.com/streamsearch/-/streamsearch-1.1.0.tgz#404dd1e2247ca94af554e841a8ef0eaa238da764"
3103-
integrity sha512-Mcc5wHehp9aXz1ax6bZUyY5afg9u2rv5cqQI3mRrYkGC8rW2hM02jWuwjtL++LS5qinSyhj2QfLyNsuc+VsExg==
3104-
31053057
string-length@^4.0.1:
31063058
version "4.0.2"
31073059
resolved "https://registry.yarnpkg.com/string-length/-/string-length-4.0.2.tgz#a8a8dc7bd5c1a82b9b3c8b87e125f66871b6e57a"
@@ -3222,14 +3174,6 @@ thenify-all@^1.0.0:
32223174
dependencies:
32233175
any-promise "^1.0.0"
32243176

3225-
tinyglobby@^0.2.14:
3226-
version "0.2.16"
3227-
resolved "https://registry.yarnpkg.com/tinyglobby/-/tinyglobby-0.2.16.tgz#1c3b7eb953fce42b226bc5a1ee06428281aff3d6"
3228-
integrity sha512-pn99VhoACYR8nFHhxqix+uvsbXineAasWm5ojXoN8xEwK5Kd3/TrhNn1wByuD52UxWRLy8pu+kRMniEi6Eq9Zg==
3229-
dependencies:
3230-
fdir "^6.5.0"
3231-
picomatch "^4.0.4"
3232-
32333177
tmpl@1.0.5:
32343178
version "1.0.5"
32353179
resolved "https://registry.yarnpkg.com/tmpl/-/tmpl-1.0.5.tgz#8683e0b902bb9c20c4f726e3c0b69f36518c07cc"
@@ -3261,14 +3205,6 @@ ts-jest@^29.1.0:
32613205
semver "^7.5.3"
32623206
yargs-parser "^21.0.1"
32633207

3264-
ts-morph@^28.0.0:
3265-
version "28.0.0"
3266-
resolved "https://registry.yarnpkg.com/ts-morph/-/ts-morph-28.0.0.tgz#cd3ebdf89742a32b06ea7327df6445364ee26631"
3267-
integrity sha512-Wp3tnZ2bzwxyTZMtgWVzXDfm7lB1Drz+y9DmmYH/L702PQhPyVrp3pkou3yIz4qjS14GY9kcpmLiOOMvl8oG1g==
3268-
dependencies:
3269-
"@ts-morph/common" "~0.29.0"
3270-
code-block-writer "^13.0.3"
3271-
32723208
ts-node@^10.5.0:
32733209
version "10.7.0"
32743210
resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-10.7.0.tgz#35d503d0fab3e2baa672a0e94f4b40653c2463f5"

0 commit comments

Comments
 (0)