Skip to content

Commit c21b441

Browse files
feat: Fix browser pool update schema
1 parent ab1e03f commit c21b441

3 files changed

Lines changed: 11 additions & 40 deletions

File tree

.stats.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
configured_endpoints: 117
2-
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/kernel/kernel-1acd8f0b76ab00e36b53cc3ca90b72b2199f3388b3e307890adb464b87f9a2d8.yml
3-
openapi_spec_hash: 82003125c1c2c5d82d19270bafb4a6ca
2+
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/kernel/kernel-2d1337eec44e036b9c896b7db4691f0a12edfa79d3f28b611818bcedf62d44ee.yml
3+
openapi_spec_hash: 30110dbbe733b16e40a6d0aa41d0c8c4
44
config_hash: ede72e4ae65cc5a6d6927938b3455c46

src/resources/browser-pools.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ export class BrowserPools extends APIResource {
4848
* ```ts
4949
* const browserPool = await client.browserPools.update(
5050
* 'id_or_name',
51-
* { size: 10 },
5251
* );
5352
* ```
5453
*/
@@ -494,13 +493,6 @@ export interface BrowserPoolCreateParams {
494493
}
495494

496495
export interface BrowserPoolUpdateParams {
497-
/**
498-
* Number of browsers to maintain in the pool. The maximum size is determined by
499-
* your organization's pooled sessions limit (the sum of all pool sizes cannot
500-
* exceed your limit).
501-
*/
502-
size: number;
503-
504496
/**
505497
* Custom Chrome enterprise policy overrides applied to all browsers in this pool.
506498
* Keys are Chrome enterprise policy names; values must match their expected types.
@@ -554,6 +546,13 @@ export interface BrowserPoolUpdateParams {
554546
*/
555547
proxy_id?: string;
556548

549+
/**
550+
* Number of browsers to maintain in the pool. The maximum size is determined by
551+
* your organization's pooled sessions limit (the sum of all pool sizes cannot
552+
* exceed your limit).
553+
*/
554+
size?: number;
555+
557556
/**
558557
* Optional URL to navigate to when a new browser is warmed into the pool.
559558
* Best-effort: failures to navigate do not fail pool fill. Only applied to

tests/api-resources/browser-pools.test.ts

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ describe('resource browserPools', () => {
6060
});
6161

6262
// Mock server tests are disabled
63-
test.skip('update: only required params', async () => {
64-
const responsePromise = client.browserPools.update('id_or_name', { size: 10 });
63+
test.skip('update', async () => {
64+
const responsePromise = client.browserPools.update('id_or_name', {});
6565
const rawResponse = await responsePromise.asResponse();
6666
expect(rawResponse).toBeInstanceOf(Response);
6767
const response = await responsePromise;
@@ -71,34 +71,6 @@ describe('resource browserPools', () => {
7171
expect(dataAndResponse.response).toBe(rawResponse);
7272
});
7373

74-
// Mock server tests are disabled
75-
test.skip('update: required and optional params', async () => {
76-
const response = await client.browserPools.update('id_or_name', {
77-
size: 10,
78-
chrome_policy: { foo: 'bar' },
79-
discard_all_idle: false,
80-
extensions: [{ id: 'id', name: 'name' }],
81-
fill_rate_per_minute: 0,
82-
headless: false,
83-
kiosk_mode: true,
84-
name: 'my-pool',
85-
profile: {
86-
id: 'id',
87-
name: 'name',
88-
save_changes: true,
89-
},
90-
proxy_id: 'proxy_id',
91-
start_url: 'https://example.com',
92-
stealth: true,
93-
timeout_seconds: 60,
94-
viewport: {
95-
height: 800,
96-
width: 1280,
97-
refresh_rate: 60,
98-
},
99-
});
100-
});
101-
10274
// Mock server tests are disabled
10375
test.skip('list', async () => {
10476
const responsePromise = client.browserPools.list();

0 commit comments

Comments
 (0)