fixup! feat: Change queries to use lab column information

Enforce the lab FK db_constraint on builds and tests, drop the unused
lab_id from the build tests response, and fix the tree query lab TODO.

Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>

Author: alanpeixinho

backend/kernelCI_app/migrations/0019_labs_builds_lab_tests_lab.py

@@ -24,7 +24,6 @@ class Migration(migrations.Migration):
             model_name="builds",
             name="lab",
             field=models.ForeignKey(
-                db_constraint=False,
                 null=True,
                 on_delete=django.db.models.deletion.DO_NOTHING,
                 to="kernelCI_app.labs",
@@ -34,7 +33,6 @@ class Migration(migrations.Migration):
             model_name="tests",
             name="lab",
             field=models.ForeignKey(
-                db_constraint=False,
                 null=True,
                 on_delete=django.db.models.deletion.DO_NOTHING,
                 to="kernelCI_app.labs",

backend/kernelCI_app/models.py

@@ -132,9 +132,7 @@ class Builds(models.Model):
     log_url = models.TextField(blank=True, null=True)
     log_excerpt = models.CharField(max_length=16384, blank=True, null=True)
     misc = models.JSONField(blank=True, null=True)
-    lab = models.ForeignKey(
-        Labs, db_constraint=False, null=True, on_delete=models.DO_NOTHING
-    )
+    lab = models.ForeignKey(Labs, null=True, on_delete=models.DO_NOTHING)
     status = models.CharField(
         max_length=10, choices=StatusChoices.choices, blank=True, null=True
     )
@@ -193,9 +191,7 @@ class UnitPrefix(models.TextChoices):
     input_files = models.JSONField(blank=True, null=True)
     output_files = models.JSONField(blank=True, null=True)
     misc = models.JSONField(blank=True, null=True)
-    lab = models.ForeignKey(
-        Labs, db_constraint=False, null=True, on_delete=models.DO_NOTHING
-    )
+    lab = models.ForeignKey(Labs, null=True, on_delete=models.DO_NOTHING)
     number_value = models.FloatField(blank=True, null=True)
     environment_compatible = ArrayField(models.TextField(), blank=True, null=True)
     number_prefix = models.CharField(

backend/kernelCI_app/queries/build.py

@@ -60,7 +60,6 @@ def get_build_tests(build_id: str) -> Optional[list[dict]]:
             tests.environment_compatible,
             tests.environment_misc,
             builds.status AS build__status,
-            tests.lab_id,
             -- TODO remove misc->>'runtime' fallback after lab backfill
             COALESCE(labs.name, tests.misc->>'runtime') AS lab
         FROM tests

backend/kernelCI_app/queries/tree.py

@@ -227,7 +227,7 @@ def get_tree_details_data(
                 tests.number_value AS tests_number_value,
                 tests.misc AS tests_misc,
                 tests.environment_compatible AS tests_environment_compatible,
-                -- TODO remove misc->>'lab' fallback after lab backfill
+                -- TODO remove misc->>'runtime' fallback after lab backfill
                 COALESCE(test_labs.name, tests.misc ->> 'runtime') AS tests_lab,
                 builds_filter.*,
                 incidents.id AS incidents_id,

backend/kernelCI_app/tests/unitTests/queries/build_test.py

@@ -38,7 +38,6 @@ def test_get_build_tests_success(self, mock_connection):
                 ["hardware1"],
                 {"platform": "x86_64"},
                 "PASS",
-                1,
                 "lab-a",
             )
         ]
@@ -51,7 +50,6 @@ def test_get_build_tests_success(self, mock_connection):
             ("environment_compatible",),
             ("environment_misc",),
             ("build__status",),
-            ("lab_id",),
             ("lab",),
         ]
 
@@ -67,7 +65,6 @@ def test_get_build_tests_success(self, mock_connection):
                 "environment_compatible": ["hardware1"],
                 "environment_misc": {"platform": "x86_64"},
                 "build__status": "PASS",
-                "lab_id": 1,
                 "lab": "lab-a",
             }
         ]

backend/kernelCI_app/tests/unitTests/views/fixtures/build_data.py

@@ -47,6 +47,5 @@
     "start_time": datetime.now(),
     "environment_compatible": ["test_environment_compatible"],
     "environment_misc": {"test_environment_misc": "test_environment_misc"},
-    "lab_id": 1,
     "lab": "test_lab",
 }

backend/kernelCI_app/typeModels/buildDetails.py

@@ -53,7 +53,6 @@ class BuildTestItem(BaseModel):
     start_time: Test__StartTime
     environment_compatible: Test__EnvironmentCompatible
     environment_misc: Test__EnvironmentMisc
-    lab_id: Optional[int]
     lab: Optional[str]