feat: labs listing#1985
Draft
felipebergamin wants to merge 4 commits into
Draft
Conversation
felipebergamin
force-pushed
the
feat/1966/labs-listing-page
branch
from
July 10, 2026 17:02
48b98a2 to
017dd23
Compare
| } | ||
|
|
||
| query = """ | ||
| WITH build_counts AS ( |
Contributor
There was a problem hiding this comment.
we might be able to simplify those queries with something on the lines of
SELECT
COALESCE(labs.name, tests.misc->>'runtime') AS lab,
CASE
WHEN status IN ('PASS', 'FAIL') THEN status
ELSE 'INCONCLUSIVE'
END AS test_status,
count(*) as test_count
FROM tests
left join labs on labs.id = tests.lab_id
WHERE COALESCE(labs.name, tests.misc->>'runtime') IS NOT null
GROUP BY
lab,
test_status;
| import type { LabsListingRoutesMap } from '@/utils/constants/labsListing'; | ||
|
|
||
| const statusCell = ( | ||
| summary: LabListingItem['build_status_summary'], |
Contributor
There was a problem hiding this comment.
the type shouldnt be a ShortStatusCount here?
| from kernelCI_app.queries.labs import get_lab_listing_data | ||
|
|
||
|
|
||
| class TestGetLabListingData: |
Contributor
There was a problem hiding this comment.
I dont know if this test aggregates much. Might be better to add Integration tests for database query tests.
| end_date=ANY, | ||
| ) | ||
| self.assertEqual(response.data["labs"][0]["lab_name"], "lab-collabora") | ||
| self.assertEqual(response.data["labs"][0]["build_status_summary"]["PASS"], 0) |
Contributor
There was a problem hiding this comment.
might be worth it checking asserting response here
| ) | ||
|
|
||
|
|
||
| class LabListingQueryParams(BaseModel): |
Contributor
There was a problem hiding this comment.
Might be worth to checking if we can use ListingQueryParams, this way we would keep the same interface as similar listings.
| status_code=HTTPStatus.OK, | ||
| ) | ||
| except ValidationError as e: | ||
| return Response(data=e.json(), status=HTTPStatus.INTERNAL_SERVER_ERROR) |
Contributor
There was a problem hiding this comment.
nit: there is a helper that other views are using create_error_reponse.
| test_status_summary: ShortStatusCount; | ||
| }; | ||
|
|
||
| export type LabListingApiItem = LabListingItem; |
Contributor
There was a problem hiding this comment.
Why are we exporting the same type twice here?
Part of kernelci#1966 Signed-off-by: Felipe Bergamin <felipebergamin@profusion.mobi>
Closes kernelci#1966 Signed-off-by: Felipe Bergamin <felipebergamin@profusion.mobi>
Signed-off-by: Felipe Bergamin <felipebergamin6@gmail.com>
Signed-off-by: Felipe Bergamin <felipebergamin6@gmail.com>
felipebergamin
force-pushed
the
feat/1966/labs-listing-page
branch
from
July 17, 2026 21:37
017dd23 to
7d53fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #1968
Visual reference
Screen.Recording.2026-07-20.at.09.55.25.mov