fix/trees report same url branch hash#1999
Open
alanpeixinho wants to merge 1 commit into
Open
Conversation
Trees that share git_url and branch could return the wrong checkout when they also share a commit hash, because tree_name was not applied in head selection or the join back to checkouts. Accept tree_name on the tree-report API and thread it through get_checkout_summary_data. Closes kernelci#1460 Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
alanpeixinho
force-pushed
the
fix/trees-report-same-url-branch-hash
branch
from
July 17, 2026 20:42
ccbfc42 to
fe69fe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it is
Tree-report could return the wrong tree when several
tree_names share the same git url/branch/hash (e.g.fedora-elnvsc10sonark-latest). Accept optionaltree_nameand use it in head selection and the checkout join.How to test
LIMIT_MAX_AGE_HOURS(720). Temporarily set it to a higher value (>4800) intreeReport.py. (Alternativelly you can produce checkouts that have origin, git_url, git_branch and hash in common, but different tree name).dashboard_urlmatches the requestedtree_name.LIMIT_MAX_AGE_HOURSto 720.pytest backend/kernelCI_app/tests/integrationTests/treeReport_test.py.Closes #1460