confd: fix possible NULL pointer deref.

troglobit · troglobit · commit 089b16002952 · 2025-10-31T16:59:30.000+01:00
Found by Coverity Scan

Signed-off-by: Joachim Wiberg &lt;troglobit@gmail.com&gt;
diff --git a/src/confd/src/infix-firewall.c b/src/confd/src/infix-firewall.c
@@ -68,6 +68,9 @@ static void mark_interfaces_used(struct lyd_node *cfg, char **ifaces)
 {
 	struct lyd_node *node;
 
+	if (!ifaces)
+		return;
+
 	LYX_LIST_FOR_EACH(lyd_child(cfg), node, "interface") {
 		const char *ifname = lyd_get_value(node);
 

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,9 @@ static void mark_interfaces_used(struct lyd_node cfg, char *ifaces)`
`68`	`68`	`{`
`69`	`69`	`struct lyd_node *node;`
`70`	`70`
	`71`	`+ if (!ifaces)`
	`72`	`+ return;`
	`73`	`+`
`71`	`74`	`LYX_LIST_FOR_EACH(lyd_child(cfg), node, "interface") {`
`72`	`75`	`const char *ifname = lyd_get_value(node);`
`73`	`76`