test: add container suite cleanup case

Persistent podman storage on test hardware can hold containers from
earlier deployments or test runs, completely unrelated to the current
suite.  Those stale containers still appear in operational data.

Add a new 'Container Cleanup' case as the first entry of the
container suite.  It SSHes into the target and wipes all containers
and volumes via 'podman rm -af' / 'podman volume prune -af', then
verifies 'podman ps -aq' is empty, guaranteeing a known clean state
before the rest of the suite runs.

Signed-off-by: Richard Alpe <richard@bit42.se>

Author: rical

test/case/containers/Readme.adoc

@@ -3,6 +3,7 @@
 
 Tests verifying link:https://opencontainers.org/[OCI container] support:
 
+ - Cleanup of any stale containers/volumes before the suite runs
  - Basic web server container running in host network mode
  - Container enable/disable functionality via configuration  
  - Container environment variable configuration and access
@@ -13,6 +14,10 @@ Tests verifying link:https://opencontainers.org/[OCI container] support:
  - Container upgrade using RPC with cleanup of old image
  - Firewall container running in host network mode with full privileges
 
+include::cleanup/Readme.adoc[]
+
+<<<
+
 include::basic/Readme.adoc[]
 
 <<<

test/case/containers/all.yaml

@@ -1,5 +1,8 @@
 ---
 
+- name: Container Cleanup
+  case: cleanup/test.py
+
 - name: Container Basic
   case: basic/test.py
 

test/case/containers/cleanup/Readme.adoc

@@ -0,0 +1 @@
+test.adoc

test/case/containers/cleanup/test.adoc

@@ -0,0 +1,26 @@
+=== Container Cleanup
+
+ifdef::topdoc[:imagesdir: {topdoc}../../test/case/containers/cleanup]
+
+==== Description
+
+Remove all containers and volumes from the target before running other
+container tests.  Persistent podman storage on test hardware can hold
+stale containers from earlier deployments or test runs, which then
+appear in operational data and may trip YANG validation -- making
+unrelated tests look flaky.
+
+This test runs first in the container suite to guarantee a known-empty
+podman state.
+
+==== Topology
+
+image::topology.svg[Container Cleanup topology, align=center, scaledwidth=75%]
+
+==== Sequence
+
+. Set up topology and attach to target DUT
+. Remove all containers and volumes via podman
+. Verify no containers remain
+
+

test/case/containers/cleanup/test.py

@@ -0,0 +1,36 @@
+#!/usr/bin/env python3
+"""Container Cleanup
+
+Remove all containers and volumes from the target before running other
+container tests.  Persistent podman storage on test hardware can hold
+stale containers from earlier deployments or test runs, which then
+appear in operational data and may trip YANG validation -- making
+unrelated tests look flaky.
+
+This test runs first in the container suite to guarantee a known-empty
+podman state.
+"""
+import infamy
+import infamy.ssh as ssh
+
+
+with infamy.Test() as test:
+    with test.step("Set up topology and attach to target DUT"):
+        env = infamy.Env()
+        target = env.attach("target", "mgmt")
+        tgtssh = env.attach("target", "mgmt", "ssh")
+
+        if not target.has_model("infix-containers"):
+            test.skip()
+
+    with test.step("Remove all containers and volumes via podman"):
+        tgtssh.runsh("sudo podman rm -af")
+        tgtssh.runsh("sudo podman volume prune -af")
+
+    with test.step("Verify no containers remain"):
+        out = tgtssh.runsh("sudo podman ps -aq").stdout.strip()
+        if out:
+            print(f"Containers still present: {out!r}")
+            test.fail()
+
+    test.succeed()

test/case/containers/cleanup/topology.dot

@@ -0,0 +1 @@
+../../../infamy/topologies/1x1.dot

test/case/containers/cleanup/topology.svg

@@ -9,7 +9,6 @@
         "running": true,
         "status": "Up About a minute",
         "cmdline": "/usr/bin/tini -- /usr/sbin/httpd -f -v",
-        "command": "/usr/sbin/httpd -f -v",
         "network": {
           "interface": [
             {
@@ -30,7 +29,6 @@
         "running": true,
         "status": "Up About a minute",
         "cmdline": "/usr/bin/tini -- /usr/sbin/httpd -f -v -p 91",
-        "command": "/usr/sbin/httpd -f -v -p 91",
         "network": {
           "interface": [
             {
@@ -53,7 +51,6 @@
         "running": true,
         "status": "Up About a minute",
         "cmdline": "/usr/bin/tini -- /usr/sbin/nft-helper /etc/nftables.conf",
-        "command": "/usr/sbin/nft-helper /etc/nftables.conf",
         "network": {
           "host": true
         }

test/case/statd/containers/infix-containers.json

@@ -1188,7 +1188,6 @@
     "container": [
       {
         "cmdline": "/usr/bin/tini -- /usr/sbin/httpd -f -v",
-        "command": "/usr/sbin/httpd -f -v",
         "id": "78d28082c2e5d494c82aa181c95118ce498e25930ad9e288ba010257ca336378",
         "image": "localhost/curios-httpd-oci-amd64-v24.11.0:latest",
         "image-id": "d6930d60a73be9980f8e19b4b4f63586a6d3492178e20bea962e4e9b8c654033",
@@ -1209,7 +1208,6 @@
       },
       {
         "cmdline": "/usr/bin/tini -- /usr/sbin/httpd -f -v -p 91",
-        "command": "/usr/sbin/httpd -f -v -p 91",
         "id": "3451cfceca4eee1091c1dfedece2faee99bc8a729e781799d9c0b4368a31d86d",
         "image": "localhost/curios-httpd-oci-amd64-v24.11.0:latest",
         "image-id": "d6930d60a73be9980f8e19b4b4f63586a6d3492178e20bea962e4e9b8c654033",
@@ -1232,7 +1230,6 @@
       },
       {
         "cmdline": "/usr/bin/tini -- /usr/sbin/nft-helper /etc/nftables.conf",
-        "command": "/usr/sbin/nft-helper /etc/nftables.conf",
         "id": "4e7c3daeba15546e7640014b9ee46e389737ed36583e5cb2f8b75a07a82e8523",
         "image": "localhost/curios-nftables-oci-amd64-v24.11.0:latest",
         "image-id": "7a3cc502436250357a6664100a600f306334b4d7203890b85b7ea9b8da6b5665",