Skip to content

Verify auto-negotiated speed/duplex#1059

Merged
axkar merged 2 commits into
mainfrom
speed_duplex
Jun 25, 2025
Merged

Verify auto-negotiated speed/duplex#1059
axkar merged 2 commits into
mainfrom
speed_duplex

Conversation

@axkar
Copy link
Copy Markdown
Collaborator

@axkar axkar commented Jun 9, 2025 •
edited
Loading

Verify that auto-negotiation results in expected speed/duplex mode.

Fixed #976

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
    • Docker image upgrade
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@axkar axkar self-assigned this Jun 9, 2025
@axkar axkar marked this pull request as draft June 9, 2025 13:16
@axkar axkar marked this pull request as ready for review June 9, 2025 14:02
@axkar axkar force-pushed the speed_duplex branch 3 times, most recently from 76d2a1c to 60e3fa0 Compare June 11, 2025 13:21
@axkar axkar requested a review from wkz June 11, 2025 15:39
wkz
wkz requested changes Jun 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👏 👏

How big of an effort would it be to add tests for setting static speed duplex on the target side while we're at it?

Comment thread test/case/ietf_interfaces/speed_duplex_copper/test.py
Comment thread test/case/ietf_interfaces/speed_duplex_copper/test.py Outdated
Comment thread test/case/ietf_interfaces/speed_duplex_copper/test.py
Comment thread test/case/ietf_interfaces/speed_duplex_copper/test.py Outdated
mattiaswal
mattiaswal approved these changes Jun 18, 2025
View reviewed changes
Comment thread test/case/ietf_interfaces/speed_duplex_copper/test.py Outdated
@mattiaswal mattiaswal self-requested a review June 18, 2025 06:00
@axkar
Copy link
Copy Markdown
Collaborator Author

axkar commented Jun 18, 2025

Looks good! 👏 👏

How big of an effort would it be to add tests for setting static speed duplex on the target side while we're at it?

Not much. I can add them :)

@axkar axkar force-pushed the speed_duplex branch 2 times, most recently from f5c7a83 to 460a929 Compare June 23, 2025 16:07
@axkar axkar requested a review from wkz June 24, 2025 07:53
wkz
wkz requested changes Jun 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 💪

Comment thread test/case/ietf_interfaces/speed_duplex_copper/test.py
Comment thread test/case/ietf_interfaces/speed_duplex_copper/speed_duplex_copper.adoc Outdated
wkz
wkz approved these changes Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

test/docker: Upgrade docker image to include ethtool
20d5426 
Add `ethtool` to the Docker test environment to support
interface auto-negotiation tests.
@axkar axkar merged commit edd2e60 into main Jun 25, 2025
5 checks passed
@axkar axkar deleted the speed_duplex branch June 25, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wkz wkz wkz approved these changes

@mattiaswal mattiaswal Awaiting requested review from mattiaswal

Assignees

@axkar axkar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Auto-test for speed/duplex auto-negotiation on copper ports

3 participants

@axkar @wkz @mattiaswal