test & fix: add DHCPv4 client hostname resend regression test, fix hostname resend #1480
Merged
troglobit merged 3 commits intokernelkit:mainfrom Apr 28, 2026
Merged
Conversation
saba8814
changed the title
saba8814
force-pushed
the
test/dhcp-client-hostname-not-resent
branch
from
3f2df25 to
b2c4053
Compare
troglobit
requested changes
Apr 28, 2026
Comment on lines
+6
to
+28
|
|
||
| Verify that updating the system hostname regenerates the DHCP client | ||
| Finit service file so subsequent DHCP requests advertise the current | ||
| hostname (option 12, RFC 2132). | ||
|
|
||
| Regression test for a bug where the DHCP client callback only reacts | ||
| on diffs in infix-dhcp-client, so a standalone change of | ||
| ietf-system:system/hostname leaves the previously written | ||
| /etc/finit.d/available/dhcp-client-<iface>.conf untouched and the | ||
| running udhcpc keeps announcing the old name. | ||
|
|
||
| ==== Topology | ||
|
|
||
| image::topology.svg[DHCP Hostname Resend topology, align=center, scaledwidth=75%] | ||
|
|
||
| ==== Sequence | ||
|
|
||
| . Set up topology and attach to target DUT | ||
| . Configure initial hostname '{HOSTNM_A}' | ||
| . Enable DHCP client sending hostname option | ||
| . Verify Finit service carries hostname '{HOSTNM_A}' | ||
| . Update system hostname to '{HOSTNM_B}' | ||
| . Verify Finit service is regenerated with '{HOSTNM_B}' |
Contributor
There was a problem hiding this comment.
The contents are out-of-date with the test, please run make test-spec to update.
Contributor
Author
There was a problem hiding this comment.
@troglobit thank you for review, should be fixed now.
Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
saba8814
force-pushed
the
test/dhcp-client-hostname-not-resent
branch
from
b2c4053 to
08ca47f
Compare
Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
troglobit
approved these changes
Apr 28, 2026
Contributor
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Awesome, thanks! I'll merge as soon as the tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: