delete: removed theoretical points and added new QEMU brand shortcut for VM::CPU_BRAND

Author: kernelwernel

src/cli.cpp

@@ -1008,10 +1008,6 @@ static void general(
 
     std::printf("\n");
 
-#ifdef __VMAWARE_DEBUG__
-    std::cout << "[DEBUG] theoretical maximum points: " << VM::total_points << "\n";
-#endif
-
     // struct containing the whole overview of the VM data
     VM::vmaware vm(VM::MULTIPLE, high_threshold, all, dynamic);
 

src/vmaware.hpp

@@ -662,7 +662,6 @@ struct VM {
     static constexpr u8 settings_count = MULTIPLE - HIGH_THRESHOLD + 1; // get number of settings technique flags
     static constexpr u8 INVALID = 255; // explicit invalid technique macro
     static constexpr u16 base_technique_count = HIGH_THRESHOLD; // original technique count, constant on purpose (can also be used as a base count value if custom techniques are added)
-    static constexpr u16 maximum_points = 5510; // theoretical total points if all VM detections returned true (which is practically impossible)
     static constexpr u16 threshold_score = 150; // standard threshold score
     static constexpr u16 high_threshold_score = 300; // new threshold score from 150 to 300 if VM::HIGH_THRESHOLD flag is enabled
     static constexpr bool SHORTCUT = true; // macro for whether VM::core::run_all() should take a shortcut by skipping the rest of the techniques if the threshold score is already met
@@ -687,6 +686,7 @@ struct VM {
     // this is specifically meant for VM::detected_count() to 
     // get the total number of techniques that detected a VM
     static u8 detected_count_num; 
+    static u16 technique_count; // get total number of techniques
 
     static std::vector<enum_flags> disabled_techniques;
 
@@ -4314,6 +4314,11 @@ struct VM {
     #else
         const std::string& brand = cpu::get_brand();
 
+        // easy shortcut for QEMU
+        if (brand.rfind("QEMU Virtual CPU version", 0) == 0) {
+            return core::add(brands::QEMU);
+        }
+
         struct cstrview {
             const char* data;
             std::size_t size;
@@ -12176,10 +12181,6 @@ struct VM {
         // flags above, and get a total score 
         const u16 points = core::run_all(flags, SHORTCUT);
 
-    #if (VMA_CPP >= 23)
-        [[assume(points < maximum_points)]];
-    #endif
-
         u16 threshold = threshold_score;
 
         // if high threshold is set, the bar
@@ -12218,10 +12219,6 @@ struct VM {
         // flags above, and get a total score
         const u16 points = core::run_all(flags, SHORTCUT);
 
-    #if (VMA_CPP >= 23)
-        [[assume(points < maximum_points)]];
-    #endif
-
         u8 percent = 0;
         u16 threshold = threshold_score;
 
@@ -12842,12 +12839,6 @@ struct VM {
 
     };
     #pragma pack(pop)
-
-
-    static u16 technique_count; // get total number of techniques
-#ifdef __VMAWARE_DEBUG__
-    static u16 total_points;
-#endif
 };
 
 // ============= EXTERNAL DEFINITIONS =============
@@ -12974,10 +12965,6 @@ std::size_t VM::memo::leaf_cache::next_index = 0;
 const char* VM::core::last_detected_brand = nullptr;
 VM::u8 VM::core::last_detected_score = 0;
 
-#ifdef __VMAWARE_DEBUG__
-VM::u16 VM::total_points = 0;
-#endif
-
 // these are basically the base values for the core::arg_handler function.
 // It's like a bucket that will collect all the bits enabled. If for example 
 // VM::detect(VM::HIGH_THRESHOLD) is passed, the HIGH_THRESHOLD bit will be