Bugfix/disable func wrong return#593
Merged
kernelwernel merged 3 commits intokernelwernel:devfrom Dec 7, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes two bugs in the VMAware library: a compilation error in the DISABLE function and an incorrect platform category for the VMWARE_DMESG detection technique.
- Fixed DISABLE function to properly return flagset after calling void function
- Corrected VMWARE_DMESG categorization from Windows to Linux
- Updated documentation to reflect the platform category fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vmaware.hpp | Fixed DISABLE function return logic to call void function before returning flagset; corrected VMWARE_DMESG category from Windows to Linux; updated line number references in header comments |
| docs/documentation.md | Updated VMWARE_DMESG platform icon from Windows (🪟) to Linux (🐧) and adjusted line number references to match code changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luukjp
force-pushed
the
bugfix/disable-func-wrong-return
branch
from
b0a7c1f to
04f043a
Compare
luukjp
force-pushed
the
bugfix/disable-func-wrong-return
branch
from
157c236 to
4353346
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAKE SURE TO READ THE CONTRIBUTION GUIDELINES BEFORE CONTINUING!
What does this PR do?
Briefly explain what this PR does: