Add Support for Down to Windows 7 in the CLI by default#608
Closed
CE1CECL wants to merge 1 commit intokernelwernel:devfrom
Closed
Add Support for Down to Windows 7 in the CLI by default#608CE1CECL wants to merge 1 commit intokernelwernel:devfrom
CE1CECL wants to merge 1 commit intokernelwernel:devfrom
Conversation
Author
|
Oh, before I forget, this fixes #480 in CI builds |
There was a problem hiding this comment.
Pull request overview
Adjusts the CLI build configuration on Windows to target older Windows versions (Vista/6.0) by default without changing the public header (vmaware.hpp).
Changes:
- Adds
_WIN32_WINNT/WINVERdefines in the Windows-specific section of the CLI to target Windows Vista (0x0600). - Minor end-of-file diff cleanup (no functional change).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CE1CECL
force-pushed
the
dev
branch
3 times, most recently
from
d27a05b to
6f67af4
Compare
CE1CECL
changed the title
Scrut1ny
reviewed
Jan 24, 2026
Signed-off-by: Christopher Lentocha <christopherericlentocha@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't add it to the
vmaware.hpp, to prevent any external apps that may require newer a Windows versions at all (if XYZ app is heavy-dependant on VMAware, & to prevent XYZ app dev from reordering headers/defining more_WIN32_WINNT's in their own apps for no-reason.This will be usefull for 86Box/PCem detection testing, as they can only run up to Windows 7 (they are retro PC emulators after all, still considered VMs to me)