Modifications for more robustness#1
Open
DrPitre wants to merge 3 commits into
Open
Conversation
This script fails if there is no Safari window open. I added a check on lines 25-27 so it can handle this case.
Modified to check for Safari window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the Safari/Show|Create-Tab.applescript file to make it more robust, handling the situation where there is no open Safari window. The existing script fails if Safari is not running, or is running but has no window open.
I also added an activate just below the
tell application "Safari"line in case Safari wasn't already launched. This helps in bringing up a fresh window in that case.I tested this script with Safari 15.2 on macOS 12.1 Monterey.