Skip to content

Commit 24f2725

Browse files
kevinelliottclaude
andcommitted
Fix summary field naming for consistency (v0.5.2)
Reverted field naming from ShortSummary/Summary back to ShortText/Text in SummaryMetadata. Rationale: "Summary" is redundant when fields are already in SummaryMetadata struct. This provides cleaner naming: SummaryMetadata.Text vs SummaryMetadata.Summary Changes: - internal/bridge/events.go: ShortText + Text (JSON: short_text, text) - pkg/conversation/state.go: ShortText + Text (JSON: short_text, text) - pkg/orchestrator/orchestrator.go: Updated summaryMetadata initialization - cmd/run.go: Updated state metadata population - All test files updated accordingly All tests pass, no breaking changes to external APIs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 70427c5 commit 24f2725

14 files changed

Lines changed: 2095 additions & 20 deletions

File tree

CHANGELOG.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
## [0.5.2] - 2025-01-26
11+
12+
### Fixed
13+
- **Summary Field Naming Consistency**
14+
- Reverted field naming from `ShortSummary`/`Summary` back to `ShortText`/`Text` in `SummaryMetadata`
15+
- Rationale: "Summary" is redundant when fields are already in `SummaryMetadata` struct
16+
- Updated field naming in `StateMetadata` from `ShortSummary`/`Summary` to `ShortText`/`Text` for consistency
17+
- JSON field names: `short_text` and `text` (inside parent `summary` object)
18+
- This provides cleaner naming: `SummaryMetadata.Text` vs `SummaryMetadata.Summary`
19+
- Updated all references across:
20+
- `internal/bridge/events.go` - Event data structures
21+
- `pkg/conversation/state.go` - Conversation state persistence
22+
- `pkg/orchestrator/orchestrator.go` - Summary metadata initialization
23+
- `cmd/run.go` - State metadata population
24+
- All test files updated accordingly
25+
- All tests pass, no breaking changes to external APIs
26+
1027
## [0.5.1] - 2025-01-26
1128

1229
### Added

cmd/run.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,8 +440,8 @@ func saveConversationState(orch *orchestrator.Orchestrator, cfg *config.Config,
440440

441441
// Populate summary fields if available
442442
if summary := orch.GetSummary(); summary != nil {
443-
state.Metadata.ShortSummary = summary.ShortSummary
444-
state.Metadata.Summary = summary.Summary
443+
state.Metadata.ShortText = summary.ShortText
444+
state.Metadata.Text = summary.Text
445445
}
446446

447447
// Determine save path

0 commit comments

Comments
 (0)